From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 369F0385B804; Thu, 29 Jul 2021 09:07:27 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 369F0385B804
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101641] Bogus redundant store removal
Date: Thu, 29 Jul 2021 09:07:26 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 11.1.1
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-101641-4-e3z9uJbDqt@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-101641-4@http.gcc.gnu.org/bugzilla/>
References: <bug-101641-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2021 09:07:27 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101641

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Just some more brain-dumps from thinking about a fix.

- we can annotate the alias_set_entry with a flag whether it was created for
  a union type and use that to improve the logic

- we can introduce some dynamic-type change IL elements that would allow us
  to elide all those redundant stores but preserve their effect.  They'd
  be modeled as stores but would generate no code.  The stored value would
  be implicit so we can readily remove the load (or constant).  An
  internal function call like we have for masked stores would be a possibil=
ity
  but those would be quite disruptive to passes compared to the load/store
  sequence, so preserving the original store but with a special RHS seems
  most logical (but we cannot use RHS =3D=3D LHS as that's only valid GIMPLE
  for non-register-types).  We'd also have to be careful to not treat those
  "stores" as kills which leans towards the IFN again.

A fix along the first idea looks least intrusive for backporting.  A fix
along the second idea looks best for recovering lost redundant store remova=
l.=