[Bug fortran/101660] New: FAIL: gfortran.dg/bind_c_array_params_3.f90

[Bug fortran/101660] New: FAIL: gfortran.dg/bind_c_array_params_3.f90

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

            Bug ID: 101660
           Summary: FAIL: gfortran.dg/bind_c_array_params_3.f90
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: msebor at gcc dot gnu.org
  Target Milestone: ---

In a recent x86_64 build I see a number of failures in the gfortran test suite:

   FAIL: gfortran.dg/bind_c_array_params_3.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_10.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_11.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_12.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_15.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_16.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_17.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_18.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_1.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_3.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_5.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_6.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_7.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_8.f90 (6: -12)
   FAIL: gfortran.dg/ISO_Fortran_binding_9.f90 (6: -12)
   FAIL: gfortran.dg/iso_fortran_binding_uint8_array.f90 (6: -12)
   FAIL: gfortran.dg/pr93524.f90 (6: -12)
   FAIL: gfortran.dg/PR94327.f90 (6: -12)
   FAIL: gfortran.dg/PR94331.f90 (6: -12)

The failures have also been reported here:
https://gcc.gnu.org/pipermail/gcc-testresults/2021-July/709815.html

Most (all?) of the failures are due to:

gcc/testsuite/gfortran.dg/bind_c_array_params_3_aux.c:8:10: fatal error:
ISO_Fortran_binding.h: No such file or directory
compilation terminated.
compiler exited with status 1
FAIL: gfortran.dg/bind_c_array_params_3.f90   -O0  (test for excess errors)
Excess errors:
gcc/testsuite/gfortran.dg/bind_c_array_params_3_aux.c:8:10: fatal error:
ISO_Fortran_binding.h: No such file or directory
compilation terminated.

UNRESOLVED: gfortran.dg/bind_c_array_params_3.f90   -O0  compilation failed to
produce executable

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Target Milestone|---                         |12.0
            Summary|FAIL:                       |[12 Regression] FAIL:
                   |gfortran.dg/bind_c_array_pa |gfortran.dg/bind_c_array_pa
                   |rams_3.f90                  |rams_3.f90
   Last reconfirmed|                            |2021-07-29

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed, saw them, too.

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandra at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
The problem is the patch set for PR 101305, which moved from a static
  libgfortran/ISO_Fortran_binding.h
to a generated
  $build/$arch/libgfortran/ISO_Fortran_binding.h

And in the include file:
  -#include "../../../libgfortran/ISO_Fortran_binding.h"
  +#include "ISO_Fortran_binding.h"

I am not quite sure whether that should be "..." or now "<...>".


Notes:
* When doing incremental builds, ISO_Fortran_binding.h was not build; I had to
  delete $build/{*,*/*}/libgfortran/  (or $build to do a proper bootstrap)
  to get it generated.

* Here, it does work in that case with in-build-tree testing, except that with
  testing -m64 and -m32 at the same time, the wrong header is used,
  cf. https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576194.html


It would be useful to know:
* whether you did an incremental build or not (cf. above)

* whether your are testing in build tree or with the installed compiler.
→ If the latter, does changing "ISO_Fortran_binding.h" to
<ISO_Fortran_binding.h> help?

* Do you use RUNTESTFLAGS - in particular  --target_board=  to run multiple
archs at the
  the same time (→ email above)

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think it should be <ISO_Fortran_binding.h> .
Anyway, at least on Fedora it fails because we install the
ISO_Fortran_binding.h
header not to /usr/include but to
/usr/lib/gcc/<target>/<version>/include/ISO_Fortran_binding.h
and so when using xgcc -B ... the just built compiler can't use the system
compiler's version, which IMHO is the only reason why it could succeed for
Sandra or anyone else.
We need an -I ... option that will point the compiler to the libgfortran build
directory (and do so correctly for the current multilib).

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Submitted testsuite patch:
https://gcc.gnu.org/pipermail/gcc-patches/2021-July/576278.html

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |seurer at gcc dot gnu.org

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> ---
*** Bug 101678 has been marked as a duplicate of this bug. ***

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:527a1cf32c27a3fbeaf6be7596241570d864cc4c

commit r12-2808-g527a1cf32c27a3fbeaf6be7596241570d864cc4c
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Mon Aug 9 12:35:23 2021 +0200

    testsuite/lib/gfortran.exp: Add -I for ISO*.h [PR101305, PR101660]

    This patch adds -I$specdir/libgfortran to GFORTRAN_UNDER_TEST, when
    set by proc gfortran_init. As the $specdir depends on the multilib
    setting, it has to be re-set for a different multilib; hence, we track
    whether a previous call to gfortran_init set that var or whether it
    was set differently.

    gcc/testsuite/
            PR libfortran/101305
            PR fortran/101660

            * lib/gfortran.exp (gfortran_init): Add -I $specdir/libgfortran to
            GFORTRAN_UNDER_TEST; update it when set by previous gfortran_init
call.
            * gfortran.dg/ISO_Fortran_binding_1.c: Use <...> not "..." for
            ISO_Fortran_binding.h's #include.
            * gfortran.dg/ISO_Fortran_binding_10.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_11.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_12.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_15.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_16.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_17.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_18.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_3.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_5.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_6.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_7.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_8.c: Likewise.
            * gfortran.dg/ISO_Fortran_binding_9.c: Likewise.
            * gfortran.dg/PR94327.c: Likewise.
            * gfortran.dg/PR94331.c: Likewise.
            * gfortran.dg/bind_c_array_params_3_aux.c: Likewise.
            * gfortran.dg/iso_fortran_binding_uint8_array_driver.c: Likewise.
            * gfortran.dg/pr93524.c: Likewise.

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[ubizjak at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Uroš Bizjak <ubizjak at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ubizjak at gmail dot com

--- Comment #7 from Uroš Bizjak <ubizjak at gmail dot com> ---
*** Bug 101820 has been marked as a duplicate of this bug. ***

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Should be FIXED. Sorry for the breakage.

[Bug fortran/101660] [12 Regression] FAIL: gfortran.dg/bind_c_array_params_3.f90

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101660

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:2ba0376ac40447ce7ee09fcef00511c18db25dfa

commit r12-2839-g2ba0376ac40447ce7ee09fcef00511c18db25dfa
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Tue Aug 10 17:26:32 2021 +0200

    gfortran: Fix in-build-tree testing [PR101305, PR101660]

    ISO_Fortran_binding.h is written in the build dir - hence, a previous
commit
    added it as include directory for in-build-tree testing.  However,
    it turned out that -I$specdir/libgfortran interferes with reading .mod
files
    as they are then no longer regareded as intrinsic modules.  Solution:
Create
    an extra include/ directory in the libgfortran build dir and copy
    ISO_Fortran_binding.h to that directory.  As -B$specdir/libgfortran already
    causes gfortran to read that include subdirectory, the -I flag is no longer
    needed.

            PR libfortran/101305
            PR fortran/101660
            PR testsuite/101847

    libgfortran/ChangeLog:

            * Makefile.am (ISO_Fortran_binding.h): Create include/ in the build
dir
            and copy the include file to it.
            (clean-local): Add for removing the 'include' directory.
            * Makefile.in: Regenerate.

    gcc/testsuite/ChangeLog:

            * lib/gfortran.exp (gfortran_init): Remove -I$specpath/libgfortran
            from the string used to set GFORTRAN_UNDER_TEST.