public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug objc/101718] Objective-C frontend emits wrong code to call methods returning scalar types returned in memory
Date: Sun, 31 Mar 2024 07:52:22 +0000	[thread overview]
Message-ID: <bug-101718-4-QIOfjkqLtc@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101718-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101718

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:106cfc476a55c7423dca23be1eb0a5fb5da736b5

commit r11-11302-g106cfc476a55c7423dca23be1eb0a5fb5da736b5
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Mon Aug 16 21:22:13 2021 +0100

    Objective-C, NeXT: Fix messenging non-aggregate return-in-memory.

    When a method returns a type that the platform ABI says should be
    returned in memory, and that is done by a hidden 'sret' parameter,
    the message send calls must be adjusted to inform the runtime that
    the sret parameter is present.  As reported in the PR, this is not
    working for non-aggregate types that use this mechanism.  The fix
    here is to adjust the logic such that all return values that flag
    'in memory' are considered to use the mechanism *unless* they
    provide a struct_value_rtx *and* the return object is an aggregate.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

    PR objc/101718 - Objective-C frontend emits wrong code to call methods
returning scalar types returned in memory

            PR objc/101718

    gcc/objc/ChangeLog:

            * objc-next-runtime-abi-02.c (build_v2_build_objc_method_call):
            Revise for cases where scalar objects use an sret parameter.
            (next_runtime_abi_02_build_objc_method_call): Likwise.

    (cherry picked from commit 1cef3039b880a21fbdf4153e6fc42026619fd4ad)

  parent reply	other threads:[~2024-03-31  7:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  6:03 [Bug objc/101718] New: Objective-C frontend emits wrong code to call methods returning _Complex " mhjacobson at me dot com
2021-08-07 20:16 ` [Bug objc/101718] Objective-C frontend emits wrong code to call methods returning scalar " iains at gcc dot gnu.org
2021-08-11  1:35 ` mhjacobson at me dot com
2021-08-16 20:08 ` iains at gcc dot gnu.org
2021-08-16 20:18 ` iains at gcc dot gnu.org
2021-09-01 14:23 ` cvs-commit at gcc dot gnu.org
2022-05-31 18:32 ` cvs-commit at gcc dot gnu.org
2022-05-31 18:34 ` iains at gcc dot gnu.org
2024-03-31  7:52 ` cvs-commit at gcc dot gnu.org [this message]
2024-03-31  7:53 ` iains at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101718-4-QIOfjkqLtc@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).