From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 730673857814; Tue,  3 Aug 2021 06:32:35 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 730673857814
From: "hewillk at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/101739] New: Some function parameters in <ranges>
 missing uglify
Date: Tue, 03 Aug 2021 06:32:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: libstdc++
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: hewillk at gmail dot com
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version bug_status
 bug_severity priority component assigned_to reporter target_milestone
Message-ID: <bug-101739-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Aug 2021 06:32:35 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101739

            Bug ID: 101739
           Summary: Some function parameters in <ranges> missing uglify
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hewillk at gmail dot com
  Target Milestone: ---

Hey, Patrick, I found that you uglify some function parameters in yesterday=
=E2=80=99s
r12-2676 to prevent user-defined macros from polluting names.

There are also some function parameters missing uglifying in <ranges>, it w=
ill
be more friendly to users if they are underlined:



--- include/std/ranges
+++ include/std/ranges
@@ -1994,8 +1994,8 @@ namespace views::__adaptor
       take_view() requires default_initializable<_Vp> =3D default;

       constexpr
-      take_view(_Vp base, range_difference_t<_Vp> __count)
-       : _M_count(std::move(__count)), _M_base(std::move(base))
+      take_view(_Vp __base, range_difference_t<_Vp> __count)
+       : _M_count(std::move(__count)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -2180,8 +2180,8 @@ namespace views::__adaptor
        =3D default;

       constexpr
-      take_while_view(_Vp base, _Pred __pred)
-       : _M_pred(std::move(__pred)), _M_base(std::move(base))
+      take_while_view(_Vp __base, _Pred __pred)
+       : _M_pred(std::move(__pred)), _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3782,8 +3782,8 @@ namespace views::__adaptor
       elements_view() requires default_initializable<_Vp> =3D default;

       constexpr explicit
-      elements_view(_Vp base)
-       : _M_base(std::move(base))
+      elements_view(_Vp __base)
+       : _M_base(std::move(__base))
       { }

       constexpr _Vp
@@ -3903,14 +3903,14 @@ namespace views::__adaptor
          _Iterator() requires default_initializable<iterator_t<_Base>> =3D
default;

          constexpr explicit
-         _Iterator(iterator_t<_Base> current)
-           : _M_current(std::move(current))
+         _Iterator(iterator_t<_Base> __current)
+           : _M_current(std::move(__current))
          { }

          constexpr
-         _Iterator(_Iterator<!_Const> i)
+         _Iterator(_Iterator<!_Const> __i)
            requires _Const && convertible_to<iterator_t<_Vp>,
iterator_t<_Base>>
-           : _M_current(std::move(i._M_current))
+           : _M_current(std::move(__i._M_current))
          { }

          constexpr const iterator_t<_Base>&



Thank you again for your great contribution to <ranges>. :)=