[Bug sanitizer/101749] New: gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[Bug sanitizer/101749] New: gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[xry111 at mengyan1223 dot wang]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

            Bug ID: 101749
           Summary: gcc -static-libasan broken because libasan.a needs
                    __cxa_guard_release in libstdc++
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
          Assignee: unassigned at gcc dot gnu.org
          Reporter: xry111 at mengyan1223 dot wang
                CC: dodji at gcc dot gnu.org, dvyukov at gcc dot gnu.org,
                    jakub at gcc dot gnu.org, kcc at gcc dot gnu.org, marxin at gcc dot gnu.org
  Target Milestone: ---

Test summary:

FAIL: c-c++-common/asan/pr59063-2.c   -O0  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O0  compilation failed to produce
executable
FAIL: c-c++-common/asan/pr59063-2.c   -O1  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O1  compilation failed to produce
executable
FAIL: c-c++-common/asan/pr59063-2.c   -O2  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O2  compilation failed to produce
executable
FAIL: c-c++-common/asan/pr59063-2.c   -O3 -g  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O3 -g  compilation failed to
produce executable
FAIL: c-c++-common/asan/pr59063-2.c   -Os  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -Os  compilation failed to produce
executable
FAIL: c-c++-common/asan/pr59063-2.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O2 -flto -fno-use-linker-plugin
-flto-partition=none  compilation failed to produce executable
FAIL: c-c++-common/asan/pr59063-2.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects  (test for excess errors)
UNRESOLVED: c-c++-common/asan/pr59063-2.c   -O2 -flto -fuse-linker-plugin
-fno-fat-lto-objects  compilation failed to produce executable

$ cc dummy.c -fsanitize=address -static-libasan
/usr/bin/ld:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../lib/libasan.a(sanitizer_posix_libcdep.o):
in function `__sanitizer::SetAlternateSignalStack()':
/sources/gcc-11.2.0/build/x86_64-pc-linux-gnu/libsanitizer/sanitizer_common/../../../../libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cpp:170:
undefined reference to `__cxa_guard_acquire'
/usr/bin/ld:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../lib/libasan.a(sanitizer_posix_libcdep.o):
in function `GetAltStackSize':
/sources/gcc-11.2.0/build/x86_64-pc-linux-gnu/libsanitizer/sanitizer_common/../../../../libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cpp:170:
undefined reference to `__cxa_guard_release'
/usr/bin/ld:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../lib/libasan.a(sanitizer_posix_libcdep.o):
in function `__sanitizer::UnsetAlternateSignalStack()':
/sources/gcc-11.2.0/build/x86_64-pc-linux-gnu/libsanitizer/sanitizer_common/../../../../libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cpp:170:
undefined reference to `__cxa_guard_acquire'
/usr/bin/ld:
/usr/lib/gcc/x86_64-pc-linux-gnu/11.2.0/../../../../lib/libasan.a(sanitizer_posix_libcdep.o):
in function `GetAltStackSize':
/sources/gcc-11.2.0/build/x86_64-pc-linux-gnu/libsanitizer/sanitizer_common/../../../../libsanitizer/sanitizer_common/sanitizer_posix_libcdep.cpp:170:
undefined reference to `__cxa_guard_release'
collect2: error: ld returned 1 exit status

Not sure if this is because something has changed in glibc-2.34.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-08-03
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[xry111 at mengyan1223 dot wang]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #1 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
I guess it's fixed in trunk by something in
90e46074e6b3561ae7d8ebd205127f286cc0c6b6:

@@ -166,9 +158,10 @@ bool SupportsColoredOutput(fd_t fd) {
 #if !SANITIZER_GO
 // TODO(glider): different tools may require different altstack size.
 static uptr GetAltStackSize() {
-  // SIGSTKSZ is not enough.
-  static const uptr kAltStackSize = SIGSTKSZ * 4;
-  return kAltStackSize;
+  // Note: since GLIBC_2.31, SIGSTKSZ may be a function call, so this may be
+  // more costly that you think. However GetAltStackSize is only call 2-3
times
+  // per thread so don't cache the evaluation.
+  return SIGSTKSZ * 4;
 }

Not tested though.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |100114

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
This was last changed for PR100114


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100114
[Bug 100114] libasan built against latest glibc doesn't work

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[xry111 at mengyan1223 dot wang]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #3 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
(In reply to Richard Biener from comment #2)
> This was last changed for PR100114

It's very strange that the fix is only backported to GCC 10 & 9, not 11.

I think just backporting it can resolve this issue.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[xry111 at mengyan1223 dot wang]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #4 from Xi Ruoyao <xry111 at mengyan1223 dot wang> ---
(In reply to Xi Ruoyao from comment #3)
> (In reply to Richard Biener from comment #2)
> > This was last changed for PR100114
> 
> It's very strange that the fix is only backported to GCC 10 & 9, not 11.
> 
> I think just backporting it can resolve this issue.

Wrong comment, please disregard it (or better "mark it as a spam :)

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to Xi Ruoyao from comment #4)
> Wrong comment, please disregard it (or better "mark it as a spam :)

That would lock your account. I'll tag it as obsolete instead.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |WAITING

--- Comment #6 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Xi Ruoyao from comment #1)
> I guess it's fixed in trunk by something in
> 90e46074e6b3561ae7d8ebd205127f286cc0c6b6:

Does it really fix the issue you see? I mean the unresolved references.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #6)
> (In reply to Xi Ruoyao from comment #1)
> > I guess it's fixed in trunk by something in
> > 90e46074e6b3561ae7d8ebd205127f286cc0c6b6:
> 
> Does it really fix the issue you see? I mean the unresolved references.

It should.  Before that change there is a block scope variable that needs
initialization and so that it is initialized just once (by the first thread
calling that function and other threads waiting until the initialization
completes) in a thread-safe way, it uses __cxa_guard*.
With the patch, there is no such variable, SIGSTKSZ * 4 is evaluated by each
thread as many times as the function is called.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #8 from Martin Liška <marxin at gcc dot gnu.org> ---
> It should.  Before that change there is a block scope variable that needs
> initialization and so that it is initialized just once (by the first thread
> calling that function and other threads waiting until the initialization
> completes) in a thread-safe way, it uses __cxa_guard*.
> With the patch, there is no such variable, SIGSTKSZ * 4 is evaluated by each
> thread as many times as the function is called.

Thanks for the full explanation.
So it seems it's fine on master, should I backport the fix to release branches?
Or is your fix g:d9f462fb372fb02da032cefd6b091d7582c425ae sufficient?

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Martin Liška from comment #8)
> Thanks for the full explanation.
> So it seems it's fine on master, should I backport the fix to release
> branches?

Yes, please.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |marxin at gcc dot gnu.org
      Known to fail|                            |10.3.0, 11.2.0, 9.4.0
      Known to work|                            |12.0

--- Comment #10 from Martin Liška <marxin at gcc dot gnu.org> ---
Mine then.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:91f8a7a34cf29ae7c465603a801326767f1cc7e9

commit r11-8828-g91f8a7a34cf29ae7c465603a801326767f1cc7e9
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Aug 5 10:43:17 2021 +0200

    sanitizer: cherry pick 414482751452e54710f16bae58458c66298aaf69

    The patch is needed in order to support recent glibc (2.34).

    libsanitizer/ChangeLog:

            PR sanitizer/101749
            * sanitizer_common/sanitizer_posix_libcdep.cpp: Prevent
            generation of dependency on _cxa_guard for static
            initialization.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #12 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:6bbaa64881715b8df2d717e418eeec7b7e974a22

commit r10-10020-g6bbaa64881715b8df2d717e418eeec7b7e974a22
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Aug 5 10:43:17 2021 +0200

    sanitizer: cherry pick 414482751452e54710f16bae58458c66298aaf69

    The patch is needed in order to support recent glibc (2.34).

    libsanitizer/ChangeLog:

            PR sanitizer/101749
            * sanitizer_common/sanitizer_posix_libcdep.cpp: Prevent
            generation of dependency on _cxa_guard for static
            initialization.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-9 branch has been updated by Martin Liska
<marxin@gcc.gnu.org>:

https://gcc.gnu.org/g:11e2ac8f75060d9be432e8db1f358298a75c98d4

commit r9-9661-g11e2ac8f75060d9be432e8db1f358298a75c98d4
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Aug 5 10:43:17 2021 +0200

    sanitizer: cherry pick 414482751452e54710f16bae58458c66298aaf69

    The patch is needed in order to support recent glibc (2.34).

    libsanitizer/ChangeLog:

            PR sanitizer/101749
            * sanitizer_common/sanitizer_posix_libcdep.cc: Prevent
            generation of dependency on _cxa_guard for static
            initialization.

[Bug sanitizer/101749] gcc -static-libasan broken because libasan.a needs __cxa_guard_release in libstdc++

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101749

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #14 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixes now on all active branches.