public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date
@ 2021-08-03 18:57 pinskia at gcc dot gnu.org
2021-08-03 18:57 ` [Bug tree-optimization/101763] " pinskia at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-03 18:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101763
Bug ID: 101763
Summary: Comments in tree-vrp.c are way out of date
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: minor
Priority: P3
Component: tree-optimization
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
CC: aldyh at gcc dot gnu.org
Target Milestone: ---
The current comment in tree-vrp.c says:
Hence, if we're going to call check_all_array_refs, set
the flag on every edge now, rather than in
check_array_bounds_dom_walker's ctor; vrp_folder may clear
it from some edges. */
But there is no call any more to check_all_array_refs but rather it is:
array_checker.check
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/101763] Comments in tree-vrp.c are way out of date
2021-08-03 18:57 [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date pinskia at gcc dot gnu.org
@ 2021-08-03 18:57 ` pinskia at gcc dot gnu.org
2021-08-03 19:04 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-03 18:57 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101763
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note I found this while trying to figure out what fixed PR 59564.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/101763] Comments in tree-vrp.c are way out of date
2021-08-03 18:57 [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date pinskia at gcc dot gnu.org
2021-08-03 18:57 ` [Bug tree-optimization/101763] " pinskia at gcc dot gnu.org
@ 2021-08-03 19:04 ` pinskia at gcc dot gnu.org
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-03 19:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101763
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The change happened in r11-439.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/101763] Comments in tree-vrp.c are way out of date
2021-08-03 18:57 [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date pinskia at gcc dot gnu.org
2021-08-03 18:57 ` [Bug tree-optimization/101763] " pinskia at gcc dot gnu.org
2021-08-03 19:04 ` pinskia at gcc dot gnu.org
@ 2021-08-04 9:05 ` aldyh at gcc dot gnu.org
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-08-04 9:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101763
--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
evrp is on the chopping block for this release, and if everything goes
according to plan, so will VRP.
If VRP survives this release, we can go back and fix things like this.
However, if you feel inclined, consider a patch fixing the comment below
pre-approved :).
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug tree-optimization/101763] Comments in tree-vrp.c are way out of date
2021-08-03 18:57 [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
@ 2021-08-04 9:05 ` aldyh at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-08-04 9:05 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101763
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2021-08-04
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-04 9:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 18:57 [Bug tree-optimization/101763] New: Comments in tree-vrp.c are way out of date pinskia at gcc dot gnu.org
2021-08-03 18:57 ` [Bug tree-optimization/101763] " pinskia at gcc dot gnu.org
2021-08-03 19:04 ` pinskia at gcc dot gnu.org
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
2021-08-04 9:05 ` aldyh at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).