public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "marxin at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug gcov-profile/101773] errors when writing to .gcda file are not checked
Date: Wed, 04 Aug 2021 15:12:00 +0000 [thread overview]
Message-ID: <bug-101773-4-IWZ2p2vTPo@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101773-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101773
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|WAITING |NEW
--- Comment #7 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Vincent Lefèvre from comment #6)
> Created attachment 51259 [details]
> added missing error check on fclose in gcc/gcov-io.c
>
> Well, not all errors are detected. There is a missing test in gcc/gcov-io.c
> for fclose (which does a write system call to flush the buffers):
>
> --- a/gcc/gcov-io.c
> +++ b/gcc/gcov-io.c
> @@ -199,7 +199,8 @@ gcov_close (void)
> {
> if (gcov_var.file)
> {
> - fclose (gcov_var.file);
> + if (fclose (gcov_var.file))
> + gcov_var.error = 1;
> gcov_var.file = 0;
> }
> gcov_var.mode = 0;
>
> (also in attachment). I've tested this patch, and it solves my problem:
Great job! I was aware of the fclose, but didn't realize it fails during
flushing.
May I please install the patch on your behalf?
next prev parent reply other threads:[~2021-08-04 15:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 10:20 [Bug gcov-profile/101773] New: " vincent-gcc at vinc17 dot net
2021-08-04 10:35 ` [Bug gcov-profile/101773] " rguenth at gcc dot gnu.org
2021-08-04 11:39 ` vincent-gcc at vinc17 dot net
2021-08-04 12:39 ` marxin at gcc dot gnu.org
2021-08-04 12:50 ` vincent-gcc at vinc17 dot net
2021-08-04 14:09 ` marxin at gcc dot gnu.org
2021-08-04 14:35 ` vincent-gcc at vinc17 dot net
2021-08-04 15:12 ` marxin at gcc dot gnu.org [this message]
2021-08-04 15:15 ` vincent-gcc at vinc17 dot net
2021-08-04 15:27 ` cvs-commit at gcc dot gnu.org
2021-08-04 15:28 ` marxin at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-101773-4-IWZ2p2vTPo@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).