From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 4A15039A0079; Fri, 6 Aug 2021 11:21:21 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A15039A0079 From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/101801] vect_worthwhile_without_simd_p is broken Date: Fri, 06 Aug 2021 11:21:21 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Aug 2021 11:21:21 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101801 --- Comment #4 from Richard Biener --- (In reply to rsandifo@gcc.gnu.org from comment #3) > So maybe a less invasive fix would be to add && !VECTOR_BOOLEAN_TYPE_P > to the condition. Still no objection to killing it off instead though. Yeah, I've pondered adding && !mask_op_p - but I'm not sure if VECTOR_BOOLEAN_TYPE_P can be generic vectors (I guess not at the moment). So detecting what is a generic vector and what not seems fragile. Btw, we _do_ vectorize using vector booleans, it's just the check for vect_worthwhile_without_simd_p misclassifies the non-vector-mode types as "generic". I'm currently checking whether there's any testsuite fallout in making vect_worthwhile_without_simd_p return true unconditionally.=