public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "qinzhao at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/101832] __builtin_object_size(P->M, 1) where M ends with a flex-array behaves like sizeof()
Date: Wed, 21 Jun 2023 19:40:52 +0000	[thread overview]
Message-ID: <bug-101832-4-FrzIPceQUK@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101832-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101832

--- Comment #11 from qinzhao at gcc dot gnu.org ---
> (In reply to Jakub Jelinek from comment #3)
> > This is intentional, if you embed an aggregate with flex array into another
> > struct and ask not to cross the field boundaries (i.e. bos1), then the size
> > of that field is exactly what is the maximum size.
> 
> As we discussed in PR 107952
> (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107952):
> 
> GCC extension accepts the following two cases:
> 
> **Case 1:
> 
> struct A { char data[1]; };
> struct B { int n; struct A a; };
> 
> as if the a.data[] array is a flex-array.  
> 
> **Case 2: 
> 
> struct C { int n; struct A a; int x; };
> 
> as if a.data[] can be up to 4 elements. 
> 
> So, what's you mean by "not to cross the field boundaries" is for the above
> Case 2? 
> For Case 1, we should treat A.data as flexible array, and then B.A as a
> structure that has flexible array, therefore B.A's size is flexible too. 
> 
> Is my understanding correct?


After discussion, the following patch to clarify the above two cases was
approved:
https://gcc.gnu.org/pipermail/gcc-patches/2023-May/620122.html

with this clarification, the above case 1 is accepted as a GCC extension, but
case 2 will be deprecated. a warning option -Wflex-array-member-not-at-end is
provided to detect case 2 in the user code. 

please see also PR77650.

  parent reply	other threads:[~2023-06-21 19:40 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09 17:01 [Bug c/101832] New: " kees at outflux dot net
2021-08-09 17:10 ` [Bug c/101832] " kees at outflux dot net
2021-08-09 17:10 ` kees at outflux dot net
2021-08-09 17:16 ` jakub at gcc dot gnu.org
2021-08-09 17:50 ` kees at outflux dot net
2021-08-09 18:07 ` kees at outflux dot net
2022-08-25 20:11 ` qinzhao at gcc dot gnu.org
2023-01-20 16:46 ` qinzhao at gcc dot gnu.org
2023-01-25 21:54 ` qinzhao at gcc dot gnu.org
2023-01-26 17:00 ` qinzhao at gcc dot gnu.org
2023-01-27 16:04 ` qinzhao at gcc dot gnu.org
2023-06-21 19:40 ` qinzhao at gcc dot gnu.org [this message]
2023-06-30 18:24 ` [Bug tree-optimization/101832] " cvs-commit at gcc dot gnu.org
2023-07-19 19:27 ` qinzhao at gcc dot gnu.org
2023-07-19 19:28 ` qinzhao at gcc dot gnu.org
2023-07-19 20:03 ` qinzhao at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-101832-4-FrzIPceQUK@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).