public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/101865] _ARCH_PWR8 is not defined when using -mcpu=power8 Date: Fri, 12 Apr 2024 20:27:04 +0000 [thread overview] Message-ID: <bug-101865-4-OWDCt3fDKv@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-101865-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101865 --- Comment #20 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Peter Bergner <bergner@gcc.gnu.org>: https://gcc.gnu.org/g:aa57af93ba22865be747f926e4e5f219e7f8758a commit r14-9949-gaa57af93ba22865be747f926e4e5f219e7f8758a Author: Will Schmidt <will_schmidt@linux.ibm.com> Date: Fri Apr 12 14:55:16 2024 -0500 rs6000: Add OPTION_MASK_POWER8 [PR101865] The bug in PR101865 is the _ARCH_PWR8 predefine macro is conditional upon TARGET_DIRECT_MOVE, which can be false for some -mcpu=power8 compiles if the -mno-altivec or -mno-vsx options are used. The solution here is to create a new OPTION_MASK_POWER8 mask that is true for -mcpu=power8, regardless of Altivec or VSX enablement. Unfortunately, the only way to create an OPTION_MASK_* mask is to create a new option, which we have done here, but marked it as WarnRemoved since we do not want users using it. For stage1, we will look into how we can create ISA mask flags for use in the compiler without the need for explicit options. 2024-04-12 Will Schmidt <will_schmidt@linux.ibm.com> Peter Bergner <bergner@linux.ibm.com> gcc/ PR target/101865 * config/rs6000/rs6000-builtin.cc (rs6000_builtin_is_supported): Use TARGET_POWER8. * config/rs6000/rs6000-c.cc (rs6000_target_modify_macros): Use OPTION_MASK_POWER8. * config/rs6000/rs6000-cpus.def (POWERPC_MASKS): Add OPTION_MASK_POWER8. (ISA_2_7_MASKS_SERVER): Likewise. * config/rs6000/rs6000.cc (rs6000_option_override_internal): Update comment. Use OPTION_MASK_POWER8 and TARGET_POWER8. * config/rs6000/rs6000.h (TARGET_SYNC_HI_QI): Use TARGET_POWER8. * config/rs6000/rs6000.md (define_attr "isa"): Add p8. (define_attr "enabled"): Handle it. (define_insn "prefetch"): Use TARGET_POWER8. * config/rs6000/rs6000.opt (mpower8-internal): New. gcc/testsuite/ PR target/101865 * gcc.target/powerpc/predefine-p7-novsx.c: New test. * gcc.target/powerpc/predefine-p8-noaltivec-novsx.c: New test. * gcc.target/powerpc/predefine-p8-noaltivec.c: New test. * gcc.target/powerpc/predefine-p8-novsx.c: New test. * gcc.target/powerpc/predefine-p8-pragma-vsx.c: New test. * gcc.target/powerpc/predefine-p9-novsx.c: New test.
next prev parent reply other threads:[~2024-04-12 20:27 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-11 19:41 [Bug target/101865] New: " tuliom at ascii dot art.br 2021-08-11 20:11 ` [Bug target/101865] " segher at gcc dot gnu.org 2021-08-18 14:12 ` wschmidt at gcc dot gnu.org 2021-08-18 15:39 ` segher at gcc dot gnu.org 2021-08-24 7:39 ` guihaoc at gcc dot gnu.org 2021-08-24 16:46 ` segher at gcc dot gnu.org 2021-08-25 2:34 ` guihaoc at gcc dot gnu.org 2021-08-25 14:00 ` tuliom at ascii dot art.br 2021-08-25 14:39 ` segher at gcc dot gnu.org 2021-08-26 0:52 ` guihaoc at gcc dot gnu.org 2021-08-26 13:21 ` tuliom at ascii dot art.br 2021-08-26 13:46 ` wschmidt at gcc dot gnu.org 2021-08-26 13:56 ` tuliom at ascii dot art.br 2021-08-31 16:09 ` bergner at gcc dot gnu.org 2021-08-31 16:26 ` wschmidt at linux dot ibm.com 2021-08-31 16:37 ` segher at gcc dot gnu.org 2021-08-31 16:42 ` segher at gcc dot gnu.org 2024-04-03 22:22 ` bergner at gcc dot gnu.org 2024-04-10 2:41 ` cvs-commit at gcc dot gnu.org 2024-04-11 22:38 ` bergner at gcc dot gnu.org 2024-04-12 20:27 ` cvs-commit at gcc dot gnu.org [this message] 2024-04-12 20:28 ` bergner at gcc dot gnu.org 2024-05-02 3:38 ` cvs-commit at gcc dot gnu.org 2024-05-02 3:38 ` cvs-commit at gcc dot gnu.org 2024-05-02 13:20 ` cvs-commit at gcc dot gnu.org 2024-05-02 13:20 ` cvs-commit at gcc dot gnu.org 2024-05-02 23:09 ` cvs-commit at gcc dot gnu.org 2024-05-02 23:09 ` cvs-commit at gcc dot gnu.org 2024-05-02 23:10 ` bergner at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-101865-4-OWDCt3fDKv@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).