From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 1A740385802E; Wed, 25 Aug 2021 07:19:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A740385802E From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/101895] [11/12 Regression] SLP Vectorizer change pushes VEC_PERM_EXPR into bad location spoiling further optimization opportunities Date: Wed, 25 Aug 2021 07:19:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: tree-optimization X-Bugzilla-Version: 11.0 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 11.3 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2021 07:19:19 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D101895 --- Comment #4 from Richard Biener --- (In reply to Jeffrey A. Law from comment #3) > Understood WRT phase ordering. That was fully expected. >=20 > What I still don't understand is why moving the permute down is profitable > here or generally why moving a permute into a dependency chain is profita= ble. >=20 > ISTM that hoisting a permute up a dependency chain so that it's fed by a > load is profitable. Similarly sinking a permute to the end of a dependen= cy > chain so that it feeds a store is profitable. Moving a permute so that it > feeds or is fed by another permute is probably profitable too. Otherwise > moving a permute into the middle of a dependency chain seems like a > pessimization. Yes, I agree. As said vect_optimize_slp misses a part that pushes the permutes back towards the loads. At the moment it is designed to move everything towards the stores (or reductions) with the intend to get rid of them. If that doesn't succeed the final placement of the permutes isn't optimized - only the number of permutes is.=