public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/101929] [12 Regression] r12-7319 regress x264_r by 4% on CLX.
Date: Mon, 07 Mar 2022 09:03:54 +0000 [thread overview]
Message-ID: <bug-101929-4-7mFAde3hbT@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-101929-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101929
--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> ---
On Mon, 7 Mar 2022, crazylht at gmail dot com wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101929
>
> --- Comment #8 from Hongtao.liu <crazylht at gmail dot com> ---
> (In reply to Richard Biener from comment #7)
> > Another change to mute the effect somewhat (but not fixing x264) that was
> > mentioned is
> >
> > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> > index b2bf90576d5..acf2cc977b4 100644
> > --- a/gcc/config/i386/i386.cc
> > +++ b/gcc/config/i386/i386.cc
> > @@ -22595,7 +22595,7 @@ ix86_builtin_vectorization_cost (enum
> > vect_cost_for_stmt type_of_cost,
> > case vec_construct:
> > {
> > /* N element inserts into SSE vectors. */
> > - int cost = TYPE_VECTOR_SUBPARTS (vectype) * ix86_cost->sse_op;
> > + int cost = (TYPE_VECTOR_SUBPARTS (vectype) - 1) *
> > ix86_cost->sse_op;
> n - 1 is right for 128-bit vector, but for 256-bit vector, shouldn't it be n -
> 2, since we have a separate cost for vinserti128, and n - 4 for 512-bit one.
True! Note that without SLP the gpr->xmm move cost is not yet accounted
for (for loops the cases where we will need an actual gpr->xmm move
will be restricted to CTORs emitted in the prologue - in-loop cases
will always come from memory, so it might not be too important to get
that correct for the non-SLP case).
next prev parent reply other threads:[~2022-03-07 9:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 5:08 [Bug tree-optimization/101929] New: r12-2549 " crazylht at gmail dot com
2021-08-16 5:10 ` [Bug tree-optimization/101929] " crazylht at gmail dot com
2021-08-16 5:21 ` [Bug target/101929] " crazylht at gmail dot com
2021-08-16 9:43 ` rguenth at gcc dot gnu.org
2021-08-19 2:29 ` cvs-commit at gcc dot gnu.org
2022-02-08 13:36 ` rguenth at gcc dot gnu.org
2022-02-22 8:01 ` [Bug target/101929] [12 Regression] r12-7319 " rguenth at gcc dot gnu.org
2022-03-07 7:18 ` rguenth at gcc dot gnu.org
2022-03-07 8:22 ` crazylht at gmail dot com
2022-03-07 9:03 ` rguenther at suse dot de [this message]
2022-03-11 14:05 ` rguenth at gcc dot gnu.org
2022-05-20 3:56 ` crazylht at gmail dot com
2022-05-20 4:05 ` crazylht at gmail dot com
2022-05-20 6:17 ` rguenth at gcc dot gnu.org
2022-05-20 6:18 ` [Bug target/101929] [12/13 " rguenth at gcc dot gnu.org
2023-12-11 20:24 ` [Bug target/101929] [12/13/14 " pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-101929-4-7mFAde3hbT@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).