public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug other/102060] New: -Wprio-ctor-dtor underlines the wrong part of the source line
@ 2021-08-25 10:13 nightstrike at gmail dot com
  2021-08-25 10:17 ` [Bug c/102060] " pinskia at gcc dot gnu.org
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: nightstrike at gmail dot com @ 2021-08-25 10:13 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102060

            Bug ID: 102060
           Summary: -Wprio-ctor-dtor underlines the wrong part of the
                    source line
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nightstrike at gmail dot com
  Target Milestone: ---

We get a warning when building for windows that should be fixed, but it
highlights that the warning is slightly mistaken about where the problem is:

gcc-git/libgcc/config/i386/cygming-crtend.c:59:1: warning: constructor
priorities from 0 to 100 are reserved for the implementation [-Wprio-ctor-dtor]
   59 | static void register_frame_ctor (void) __attribute__ ((constructor
(0)));
      | ^~~~~~


The word "static" is underlined, but I presume that instead it should be
"constructor(0)".

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line
  2021-08-25 10:13 [Bug other/102060] New: -Wprio-ctor-dtor underlines the wrong part of the source line nightstrike at gmail dot com
@ 2021-08-25 10:17 ` pinskia at gcc dot gnu.org
  2021-08-25 15:44 ` msebor at gcc dot gnu.org
  2021-08-25 15:46 ` [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line due to missing location for attributes msebor at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-08-25 10:17 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102060

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2021-08-25
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed, not a regression.  Simple testcase:
void register_frame_ctor (void) __attribute__ ((constructor (0)));

Note both the C and C++ front-end's location are different and still wrong.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line
  2021-08-25 10:13 [Bug other/102060] New: -Wprio-ctor-dtor underlines the wrong part of the source line nightstrike at gmail dot com
  2021-08-25 10:17 ` [Bug c/102060] " pinskia at gcc dot gnu.org
@ 2021-08-25 15:44 ` msebor at gcc dot gnu.org
  2021-08-25 15:46 ` [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line due to missing location for attributes msebor at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-08-25 15:44 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102060

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |msebor at gcc dot gnu.org

--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
This is a general problem with attributes: they have no location information
(and I'm pretty sure there are other reports due top it).  It certainly would
be very nice to change that.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line due to missing location for attributes
  2021-08-25 10:13 [Bug other/102060] New: -Wprio-ctor-dtor underlines the wrong part of the source line nightstrike at gmail dot com
  2021-08-25 10:17 ` [Bug c/102060] " pinskia at gcc dot gnu.org
  2021-08-25 15:44 ` msebor at gcc dot gnu.org
@ 2021-08-25 15:46 ` msebor at gcc dot gnu.org
  2 siblings, 0 replies; 4+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-08-25 15:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102060

Martin Sebor <msebor at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|-Wprio-ctor-dtor underlines |-Wprio-ctor-dtor underlines
                   |the wrong part of the       |the wrong part of the
                   |source line                 |source line due to missing
                   |                            |location for attributes
                 CC|                            |dmalcolm at gcc dot gnu.org

--- Comment #3 from Martin Sebor <msebor at gcc dot gnu.org> ---
Let me CC David in case he has ideas for how to make this happen.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-25 15:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-25 10:13 [Bug other/102060] New: -Wprio-ctor-dtor underlines the wrong part of the source line nightstrike at gmail dot com
2021-08-25 10:17 ` [Bug c/102060] " pinskia at gcc dot gnu.org
2021-08-25 15:44 ` msebor at gcc dot gnu.org
2021-08-25 15:46 ` [Bug c/102060] -Wprio-ctor-dtor underlines the wrong part of the source line due to missing location for attributes msebor at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).