public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jens.seifert at de dot ibm.com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102117] New: s390: Inefficient code for 64x64=128 signed multiply for <= z13
Date: Sun, 29 Aug 2021 12:30:48 +0000 [thread overview]
Message-ID: <bug-102117-4@http.gcc.gnu.org/bugzilla/> (raw)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102117
Bug ID: 102117
Summary: s390: Inefficient code for 64x64=128 signed multiply
for <= z13
Product: gcc
Version: 8.3.1
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: jens.seifert at de dot ibm.com
Target Milestone: ---
__int128 imul128(long long a, long long b)
{
return (__int128)a * (__int128)b;
}
creates sequence with 3 multiplies:
_Z7imul128xx:
.LFB0:
.cfi_startproc
ldgr %f2,%r12
.cfi_register 12, 17
ldgr %f0,%r13
.cfi_register 13, 16
lgr %r13,%r3
mlgr %r12,%r4
srag %r1,%r3,63
msgr %r1,%r4
srag %r4,%r4,63
msgr %r4,%r3
agr %r4,%r1
agr %r12,%r4
stmg %r12,%r13,0(%r2)
lgdr %r13,%f0
.cfi_restore 13
lgdr %r12,%f2
.cfi_restore 12
br %r14
.cfi_endproc
The following sequence only requires 1 multiply:
__int128 imul128_opt(long long a, long long b)
{
unsigned __int128 x = (unsigned __int128)(unsigned long long)a;
unsigned __int128 y = (unsigned __int128)(unsigned long long)b;
unsigned long long t1 = (a >> 63) & a;
unsigned long long t2 = (b >> 63) & b;
unsigned __int128 u128 = x * y;
unsigned long long hi = (u128 >> 64) - (t1 + t2);
unsigned long long lo = (unsigned long long)u128;
unsigned __int128 res = hi;
res <<= 64;
res |= lo;
return (__int128)res;
}
_Z11imul128_optxx:
.LFB1:
.cfi_startproc
ldgr %f2,%r12
.cfi_register 12, 17
ldgr %f0,%r13
.cfi_register 13, 16
lgr %r13,%r3
mlgr %r12,%r4
lgr %r1,%r3
srag %r3,%r3,63
ngr %r3,%r1
srag %r1,%r4,63
ngr %r4,%r1
agr %r3,%r4
sgrk %r3,%r12,%r3
stg %r13,8(%r2)
lgdr %r12,%f2
.cfi_restore 12
lgdr %r13,%f0
.cfi_restore 13
stg %r3,0(%r2)
br %r14
.cfi_endproc
next reply other threads:[~2021-08-29 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 12:30 jens.seifert at de dot ibm.com [this message]
2021-08-29 12:49 ` [Bug target/102117] " jens.seifert at de dot ibm.com
2021-11-20 13:16 ` roger at nextmovesoftware dot com
2021-11-21 11:41 ` cvs-commit at gcc dot gnu.org
2021-11-25 19:17 ` roger at nextmovesoftware dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-102117-4@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).