public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jankowski938 at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/102125] New: (ARM Cortex-M3 and newer) missed optimization. memcpy not needed operations Date: Mon, 30 Aug 2021 08:27:44 +0000 [thread overview] Message-ID: <bug-102125-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102125 Bug ID: 102125 Summary: (ARM Cortex-M3 and newer) missed optimization. memcpy not needed operations Product: gcc Version: 10.2.1 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: jankowski938 at gmail dot com Target Milestone: --- uint64_t bar64(const uint8_t *rData1) { uint64_t buffer; memcpy(&buffer, rData1, sizeof(buffer)); return buffer; } compiler options: -Ox -mthumb -mcpu=cortex-my where x : 2,3,s y:3,4,7 ``` bar64: sub sp, sp, #8 mov r2, r0 ldr r0, [r0] @ unaligned ldr r1, [r2, #4] @ unaligned mov r3, sp stmia r3!, {r0, r1} ldrd r0, [sp] add sp, sp, #8 bx lr ``` it is enough to: ``` mov r3, r0 ldr r0, [r0] @ unaligned ldr r1, [r3, #4] @ unaligned bx lr ``` 32 bit memcpy is optimized correctly: Full example code: ``` uint64_t foo64(const uint8_t *rData1) { uint64_t buffer; buffer = (((uint64_t)rData1[7]) << 56)|((uint64_t)(rData1[6]) << 48)|((uint64_t)(rData1[5]) << 40)|(((uint64_t)rData1[4]) << 32)| (((uint64_t)rData1[3]) << 24)|(((uint64_t)rData1[2]) << 16)|((uint64_t)(rData1[1]) << 8)|rData1[0]; return buffer; } uint64_t bar64(const uint8_t *rData1) { uint64_t buffer; memcpy(&buffer, rData1, sizeof(buffer)); return buffer; } uint32_t foo32(const uint8_t *rData1) { uint32_t buffer; buffer = (((uint32_t)rData1[3]) << 24)|(((uint32_t)rData1[2]) << 16)|((uint32_t)(rData1[1]) << 8)|rData1[0]; return buffer; } uint32_t bar32(const uint8_t *rData1) { uint32_t buffer; memcpy(&buffer, rData1, sizeof(buffer)); return buffer; } ``` compiler output: ``` foo64: mov r3, r0 ldr r0, [r0] @ unaligned ldr r1, [r3, #4] @ unaligned bx lr bar64: sub sp, sp, #8 mov r2, r0 ldr r0, [r0] @ unaligned ldr r1, [r2, #4] @ unaligned mov r3, sp stmia r3!, {r0, r1} ldrd r0, [sp] add sp, sp, #8 bx lr foo32: ldr r0, [r0] @ unaligned bx lr bar32: ldr r0, [r0] @ unaligned bx lr ``` Clang compiles without overhead: https://godbolt.org/z/P7G7Whxqz
next reply other threads:[~2021-08-30 8:27 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-30 8:27 jankowski938 at gmail dot com [this message] 2021-08-30 8:32 ` [Bug c/102125] " jankowski938 at gmail dot com 2021-08-30 11:40 ` [Bug target/102125] " rguenth at gcc dot gnu.org 2021-08-30 19:29 ` pinskia at gcc dot gnu.org 2021-08-30 20:14 ` jankowski938 at gmail dot com 2021-08-31 11:54 ` rearnsha at gcc dot gnu.org 2021-08-31 16:42 ` rearnsha at gcc dot gnu.org 2021-09-13 10:27 ` cvs-commit at gcc dot gnu.org 2021-09-13 10:27 ` cvs-commit at gcc dot gnu.org 2021-09-13 10:27 ` cvs-commit at gcc dot gnu.org 2021-09-13 10:29 ` rearnsha at gcc dot gnu.org 2022-03-23 14:57 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102125-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).