public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
* [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe @ 2021-08-30 9:43 marxin at gcc dot gnu.org 2021-08-30 9:44 ` [Bug tree-optimization/102128] " marxin at gcc dot gnu.org ` (5 more replies) 0 siblings, 6 replies; 7+ messages in thread From: marxin at gcc dot gnu.org @ 2021-08-30 9:43 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 Bug ID: 102128 Summary: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe Product: gcc Version: 12.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: marxin at gcc dot gnu.org CC: rguenth at gcc dot gnu.org Blocks: 26163 Target Milestone: --- Since the revision, the benchmark is slower with -Ofast PGO (and LTO) on AMD and Intel machines: https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=14.477.0&plot.1=16.477.0& https://lnt.opensuse.org/db_default/v4/SPEC/graph?plot.0=286.477.0&plot.1=16.477.0 Referenced Bugs: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26163 [Bug 26163] [meta-bug] missed optimization in SPEC (2k17, 2k and 2k6 and 95) ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org @ 2021-08-30 9:44 ` marxin at gcc dot gnu.org 2021-08-30 9:44 ` marxin at gcc dot gnu.org ` (4 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: marxin at gcc dot gnu.org @ 2021-08-30 9:44 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 --- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> --- Created attachment 51375 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51375&action=edit Optimized dump on znver3 - bad ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org 2021-08-30 9:44 ` [Bug tree-optimization/102128] " marxin at gcc dot gnu.org @ 2021-08-30 9:44 ` marxin at gcc dot gnu.org 2021-08-30 10:14 ` rguenth at gcc dot gnu.org ` (3 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: marxin at gcc dot gnu.org @ 2021-08-30 9:44 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 --- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> --- Created attachment 51376 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51376&action=edit Optimized dump on znver3 - good ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org 2021-08-30 9:44 ` [Bug tree-optimization/102128] " marxin at gcc dot gnu.org 2021-08-30 9:44 ` marxin at gcc dot gnu.org @ 2021-08-30 10:14 ` rguenth at gcc dot gnu.org 2021-08-30 10:48 ` rguenth at gcc dot gnu.org ` (2 subsequent siblings) 5 siblings, 0 replies; 7+ messages in thread From: rguenth at gcc dot gnu.org @ 2021-08-30 10:14 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|unassigned at gcc dot gnu.org |rguenth at gcc dot gnu.org Status|UNCONFIRMED |ASSIGNED Last reconfirmed| |2021-08-30 Target Milestone|--- |12.0 Ever confirmed|0 |1 --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- Interesting - it must be the grouping of all SLP instances affecting this. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org ` (2 preceding siblings ...) 2021-08-30 10:14 ` rguenth at gcc dot gnu.org @ 2021-08-30 10:48 ` rguenth at gcc dot gnu.org 2021-08-30 12:04 ` cvs-commit at gcc dot gnu.org 2021-08-30 12:05 ` rguenth at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: rguenth at gcc dot gnu.org @ 2021-08-30 10:48 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> --- I see now extra .REDUC_PLUS vectorized likely because of that. I'm testing sth to keep the separate subgraph costing. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org ` (3 preceding siblings ...) 2021-08-30 10:48 ` rguenth at gcc dot gnu.org @ 2021-08-30 12:04 ` cvs-commit at gcc dot gnu.org 2021-08-30 12:05 ` rguenth at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: cvs-commit at gcc dot gnu.org @ 2021-08-30 12:04 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 --- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:89f33f44addbf9853bc3e6677db1fa941713cb6c commit r12-3222-g89f33f44addbf9853bc3e6677db1fa941713cb6c Author: Richard Biener <rguenther@suse.de> Date: Mon Aug 30 12:56:26 2021 +0200 tree-optimization/102128 - rework if-converted BB vect heuristic This reworks the previous attempt to avoid leaving around if-converted scalar code in BB vectorized loop bodies to keep costing independent subgraphs which should address the observed regression with 519.lbm_r. For this to work we now first cost all subgraphs and only after doing that proceed to emit vectorized code. 2021-08-30 Richard Biener <rguenther@suse.de> PR tree-optimization/102128 * tree-vect-slp.c (vect_bb_vectorization_profitable_p): Move scanning for if-converted scalar code to the caller and instead delay clearing the visited flag for profitable subgraphs. (vect_slp_region): Cost all subgraphs before scheduling. For if-converted BB vectorization scan for scalar COND_EXPRs and do not vectorize if any found and the cost model is very-cheap. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/102128] [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org ` (4 preceding siblings ...) 2021-08-30 12:04 ` cvs-commit at gcc dot gnu.org @ 2021-08-30 12:05 ` rguenth at gcc dot gnu.org 5 siblings, 0 replies; 7+ messages in thread From: rguenth at gcc dot gnu.org @ 2021-08-30 12:05 UTC (permalink / raw) To: gcc-bugs https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102128 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> --- Fixed. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-08-30 12:05 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-08-30 9:43 [Bug tree-optimization/102128] New: [12 Regression] Huge performance drop for 519.lbm_r since r12-3116-g9216ee6d1195d48388f825cf1b072e570129cbbe marxin at gcc dot gnu.org 2021-08-30 9:44 ` [Bug tree-optimization/102128] " marxin at gcc dot gnu.org 2021-08-30 9:44 ` marxin at gcc dot gnu.org 2021-08-30 10:14 ` rguenth at gcc dot gnu.org 2021-08-30 10:48 ` rguenth at gcc dot gnu.org 2021-08-30 12:04 ` cvs-commit at gcc dot gnu.org 2021-08-30 12:05 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).