public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102140] [12 Regression] ICE: in extract_constrain_insn, at recog.c:2670 (insn does not satisfy its constraints) with -Og -fipa-cp -fno-tree-ccp -fno-tree-ter
Date: Tue, 08 Feb 2022 19:15:10 +0000	[thread overview]
Message-ID: <bug-102140-4-fat2U9o6ha@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102140-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102140

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:0c3e491a4e5ae74bfbed6d167d403d262b5a4adc

commit r12-7111-g0c3e491a4e5ae74bfbed6d167d403d262b5a4adc
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 8 20:14:30 2022 +0100

    rs6000: Fix up vspltis_shifted [PR102140]

    The following testcase ICEs, because
    (const_vector:V4SI [
                    (const_int 0 [0]) repeated x3
                    (const_int -2147483648 [0xffffffff80000000])
                ])
    is recognized as valid easy_vector_constant in between split1 pass and
    end of RA.
    The problem is that such constants need to be split, and the only
    splitter for that is:
    (define_split
      [(set (match_operand:VM 0 "altivec_register_operand")
            (match_operand:VM 1 "easy_vector_constant_vsldoi"))]
      "VECTOR_UNIT_ALTIVEC_OR_VSX_P (<MODE>mode) && can_create_pseudo_p ()"
    There is only a single splitting pass before RA, so after that finishes,
    if something gets matched in between that and end of RA (after that
    can_create_pseudo_p () would be no longer true), it will never be
    successfully split and we ICE at final.cc time or earlier.

    The i386 backend (and a few others) already use
    (cfun->curr_properties & PROP_rtl_split_insns)
    as a test for split1 pass finished, so that some insns that should be split
    during split1 and shouldn't be matched afterwards are properly guarded.

    So, the following patch does that for vspltis_shifted too.

    2022-02-08  Jakub Jelinek  <jakub@redhat.com>

            PR target/102140
            * config/rs6000/rs6000.cc (vspltis_shifted): Return false also if
            split1 pass has finished already.

            * gcc.dg/pr102140.c: New test.

  parent reply	other threads:[~2022-02-08 19:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  6:47 [Bug target/102140] New: " zsojka at seznam dot cz
2021-08-31  7:02 ` [Bug target/102140] " pinskia at gcc dot gnu.org
2021-08-31  7:03 ` pinskia at gcc dot gnu.org
2021-08-31  7:04 ` pinskia at gcc dot gnu.org
2021-08-31 17:18 ` jakub at gcc dot gnu.org
2021-09-23 22:05 ` segher at gcc dot gnu.org
2022-02-08 13:26 ` jakub at gcc dot gnu.org
2022-02-08 19:15 ` cvs-commit at gcc dot gnu.org [this message]
2022-02-08 19:16 ` jakub at gcc dot gnu.org
2022-02-19  8:02 ` cvs-commit at gcc dot gnu.org
2022-05-10  8:23 ` cvs-commit at gcc dot gnu.org
2022-05-11  6:24 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102140-4-fat2U9o6ha@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).