From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id CD1B23839428; Tue, 10 May 2022 08:23:32 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CD1B23839428
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102140] [12 Regression] ICE: in extract_constrain_insn,
 at recog.c:2670 (insn does not satisfy its constraints) with -Og -fipa-cp
 -fno-tree-ccp -fno-tree-ter
Date: Tue, 10 May 2022 08:23:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: RESOLVED
X-Bugzilla-Resolution: FIXED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-102140-4-gjkwIoHiyp@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102140-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102140-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 10 May 2022 08:23:32 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102140

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:df8a6a1fcab38b9e4c5bcb8b9a39f847c18e9026

commit r10-10675-gdf8a6a1fcab38b9e4c5bcb8b9a39f847c18e9026
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Feb 8 20:14:30 2022 +0100

    rs6000: Fix up vspltis_shifted [PR102140]

    The following testcase ICEs, because
    (const_vector:V4SI [
                    (const_int 0 [0]) repeated x3
                    (const_int -2147483648 [0xffffffff80000000])
                ])
    is recognized as valid easy_vector_constant in between split1 pass and
    end of RA.
    The problem is that such constants need to be split, and the only
    splitter for that is:
    (define_split
      [(set (match_operand:VM 0 "altivec_register_operand")
            (match_operand:VM 1 "easy_vector_constant_vsldoi"))]
      "VECTOR_UNIT_ALTIVEC_OR_VSX_P (<MODE>mode) && can_create_pseudo_p ()"
    There is only a single splitting pass before RA, so after that finishes,
    if something gets matched in between that and end of RA (after that
    can_create_pseudo_p () would be no longer true), it will never be
    successfully split and we ICE at final.cc time or earlier.

    The i386 backend (and a few others) already use
    (cfun->curr_properties & PROP_rtl_split_insns)
    as a test for split1 pass finished, so that some insns that should be s=
plit
    during split1 and shouldn't be matched afterwards are properly guarded.

    So, the following patch does that for vspltis_shifted too.

    2022-02-08  Jakub Jelinek  <jakub@redhat.com>

            PR target/102140
            * config/rs6000/rs6000.c (vspltis_shifted): Return false also if
            split1 pass has finished already.

            * gcc.dg/pr102140.c: New test.

    (cherry picked from commit 0c3e491a4e5ae74bfbed6d167d403d262b5a4adc)=