public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "tschwinge at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102215] New: [GCN offloading] Missing '__atomic_compare_exchange_1' etc.
Date: Mon, 06 Sep 2021 09:55:54 +0000	[thread overview]
Message-ID: <bug-102215-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102215

            Bug ID: 102215
           Summary: [GCN offloading] Missing '__atomic_compare_exchange_1'
                    etc.
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: openmp
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: tschwinge at gcc dot gnu.org
                CC: ams at gcc dot gnu.org, jakub at gcc dot gnu.org, jules at gcc dot gnu.org
  Target Milestone: ---
            Target: GCN

The recent commit 090f0d78f194e3cda23fe904016db77ea36c38fa "openmp: Improve
expand_omp_atomic_pipeline" regresses GCN offloading testing as follows:

    [-PASS:-]{+FAIL:+} libgomp.c/../libgomp.c-c++-common/reduction-16.c (test
for excess errors)
    [-PASS:-]{+UNRESOLVED:+} libgomp.c/../libgomp.c-c++-common/reduction-16.c
[-execution test-]{+compilation failed to produce executable+}

    ld: error: undefined symbol: __atomic_compare_exchange_1
    >>> referenced by /tmp/cce2YauE.o:(test_char._omp_fn.1)
    >>> referenced by /tmp/cce2YauE.o:(test_char._omp_fn.1)
    >>> referenced by /tmp/cce2YauE.o:(test_char._omp_fn.0)
    >>> referenced by /tmp/cce2YauE.o:(test_char._omp_fn.0)

    ld: error: undefined symbol: __atomic_compare_exchange_2
    >>> referenced by /tmp/cce2YauE.o:(test_short._omp_fn.1)
    >>> referenced by /tmp/cce2YauE.o:(test_short._omp_fn.1)
    >>> referenced by /tmp/cce2YauE.o:(test_short._omp_fn.0)
    >>> referenced by /tmp/cce2YauE.o:(test_short._omp_fn.0)
    collect2: error: ld returned 1 exit status
    mkoffload: fatal error:
[...]/gcc/x86_64-pc-linux-gnu-accel-amdgcn-amdhsa-gcc returned 1 exit status

Similar for 'libgomp.c++/../libgomp.c-c++-common/reduction-16.c'.

And:

    [-PASS:-]{+FAIL:+} libgomp.c/target-43.c (test for excess errors)
    [-PASS:-]{+UNRESOLVED:+} libgomp.c/target-43.c [-execution
test-]{+compilation failed to produce executable+}

    ld: error: undefined symbol: __atomic_compare_exchange_1
    >>> referenced by /tmp/cc1Kwlmj.o:(main._omp_fn.0)
    >>> referenced by /tmp/cc1Kwlmj.o:(main._omp_fn.0)
    collect2: error: ld returned 1 exit status
    mkoffload: fatal error:
[...]/gcc/x86_64-pc-linux-gnu-accel-amdgcn-amdhsa-gcc returned 1 exit status

These all do:

    { dg-additional-options "-foffload-options=nvptx-none=-latomic" { target {
offload_target_nvptx } } }

Do we now also need libatomic for GCN or should this be handled in the GCN back
end?

             reply	other threads:[~2021-09-06  9:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06  9:55 tschwinge at gcc dot gnu.org [this message]
2021-09-06  9:59 ` [Bug target/102215] " jakub at gcc dot gnu.org
2021-09-06 11:09 ` burnus at gcc dot gnu.org
2021-09-06 12:01 ` jakub at gcc dot gnu.org
2022-03-09 18:35 ` cvs-commit at gcc dot gnu.org
2022-03-10 12:07 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102215-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).