From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 687B03858D39; Fri, 26 Nov 2021 08:50:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 687B03858D39 From: "luoxhu at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug target/102239] powerpc suboptimal boolean test of contiguous bits Date: Fri, 26 Nov 2021 08:50:48 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: target X-Bugzilla-Version: 11.2.1 X-Bugzilla-Keywords: missed-optimization X-Bugzilla-Severity: normal X-Bugzilla-Who: luoxhu at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Nov 2021 08:50:48 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102239 --- Comment #4 from luoxhu at gcc dot gnu.org --- Simply adjust the sequence of dot instruction could produce expected code, = is this correct? foo: .LFB0: .cfi_startproc rldicr. 3,3,29,1 beq 0,.L2 #APP # 10 "pr102239.c" 1 # if # 0 "" 2 #NO_APP blr .p2align 4,,15 .L2: #APP # 12 "pr102239.c" 1 # else # 0 "" 2 #NO_APP blr git diff diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c index c9ce0550df1..2f0b5992bbf 100644 --- a/gcc/config/rs6000/rs6000.c +++ b/gcc/config/rs6000/rs6000.c @@ -11749,9 +11749,9 @@ rs6000_emit_2insn_and (machine_mode mode, rtx *operands, bool expand, int dot) { rtx tmp =3D gen_rtx_ASHIFT (mode, operands[1], GEN_INT (shift)); tmp =3D gen_rtx_AND (mode, tmp, GEN_INT (val << shift)); - emit_move_insn (operands[0], tmp); - tmp =3D gen_rtx_LSHIFTRT (mode, operands[0], GEN_INT (shift)); rs6000_emit_dot_insn (operands[0], tmp, dot, dot ? operands[3] : = 0); + tmp =3D gen_rtx_LSHIFTRT (mode, operands[0], GEN_INT (shift)); + emit_move_insn (operands[0], tmp); } return; }=