public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102252] svbool_t with SVE can generate invalid assembly
Date: Mon, 13 Sep 2021 14:42:33 +0000	[thread overview]
Message-ID: <bug-102252-4-1lUsOWvnje@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102252-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102252

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Kyrylo Tkachov <ktkachov@gcc.gnu.org>:

https://gcc.gnu.org/g:512b383534785f9fc021e700a1fdda86cf0f3fe7

commit r12-3490-g512b383534785f9fc021e700a1fdda86cf0f3fe7
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date:   Mon Sep 13 15:40:28 2021 +0100

    aarch64: PR target/102252 Invalid addressing mode for SVE load predicate

    In the testcase we generate invalid assembly for an SVE load predicate
instruction.
    The RTL for the insn is:
    (insn 9 8 10 (set (reg:VNx16BI 68 p0)
            (mem:VNx16BI (plus:DI (mult:DI (reg:DI 1 x1 [93])
                        (const_int 8 [0x8]))
                    (reg/f:DI 0 x0 [92])) [2 work_3(D)->array[offset_4(D)]+0 S8
A16]))

    That addressing mode is not valid for the instruction [1] as it only
accepts the addressing mode:
    [<Xn|SP>{, #<imm>, MUL VL}]

    This patch rejects the register index form for SVE predicate modes.

    Bootstrapped and tested on aarch64-none-linux-gnu.

    [1]
https://developer.arm.com/documentation/ddi0602/2021-06/SVE-Instructions/LDR--predicate---Load-predicate-register-

    gcc/ChangeLog:

            PR target/102252
            * config/aarch64/aarch64.c (aarch64_classify_address): Don't allow
            register index for SVE predicate modes.

    gcc/testsuite/ChangeLog:

            PR target/102252
            * g++.target/aarch64/sve/pr102252.C: New test.

  parent reply	other threads:[~2021-09-13 14:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09  9:41 [Bug target/102252] New: " gilles.gouaillardet at gmail dot com
2021-09-09  9:43 ` [Bug target/102252] " gilles.gouaillardet at gmail dot com
2021-09-09 10:39 ` ktkachov at gcc dot gnu.org
2021-09-09 10:56 ` ktkachov at gcc dot gnu.org
2021-09-09 11:01 ` ktkachov at gcc dot gnu.org
2021-09-13 14:42 ` cvs-commit at gcc dot gnu.org [this message]
2021-09-21  2:06 ` gilles.gouaillardet at gmail dot com
2024-01-26  6:55 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102252-4-1lUsOWvnje@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).