public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mimomorin at gmail dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/102259] New: ifstream::read(…, count) fails when count >= 2^31 on darwin
Date: Thu, 09 Sep 2021 14:39:57 +0000	[thread overview]
Message-ID: <bug-102259-4@http.gcc.gnu.org/bugzilla/> (raw)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102259

            Bug ID: 102259
           Summary: ifstream::read(…, count) fails when count >= 2^31 on
                    darwin
           Product: gcc
           Version: 11.2.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mimomorin at gmail dot com
  Target Milestone: ---

Created attachment 51431
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51431&action=edit
Testcase for ifstream::read(…, count >= 2^31)

I tried to read a large file using `ifstream::read` on Mac, but it fails to
read any byte when count >= 2^31. Note that the system is 64-bit and
`std::streamsize` has 8 bytes.
Here is a testcase.

#include <iostream>
#include <fstream>
int main() {
    std::ifstream is{"2GB.bin", std::ios::binary}; // filesize >= 2^31 bytes
    auto buffer = new char[1LL << 31];
    is.read(buffer, 1LL << 31);
    std::cout << is.good() << " (" << is.gcount() << " bytes)\n";
    // Expected output: "1 (2147483648 bytes)"
    // Actual output (on Mac): "0 (0 bytes)"
}

My system is macOS 10.15 running on x86_64 Mac. The testcase failed on
Homebrew's GCC (ver. 6, 9, 10, 11) and MacPorts' GCC (ver. 6), but it succeeded
on LLVM Clang (trunk) and Apple Clang (ver. 12).

`ifstream::read(…, count)` works fine when count < 2^31. So if we split 
    is.read(buffer, 1LL << 31);
into
    is.read(buffer, (1LL << 31) - 1);
    is.read(buffer + (1LL << 31) - 1, 1);
then everything goes OK.
Additionally, `istringstream::read(…, count >= 2^31)` works fine both on GCC
and Clang.

I don't think this simple issue went unnoticed, so maybe I've missed something.

             reply	other threads:[~2021-09-09 14:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-09 14:39 mimomorin at gmail dot com [this message]
2021-09-09 20:22 ` [Bug libstdc++/102259] " redi at gcc dot gnu.org
2021-09-10  9:05 ` mimomorin at gmail dot com
2021-09-10 20:31 ` pinskia at gcc dot gnu.org
2021-09-11  3:27 ` mimomorin at gmail dot com
2021-09-11  3:32 ` mimomorin at gmail dot com
2021-09-13  9:14 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102259-4@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).