public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug rtl-optimization/102306] [9/10/11/12 Regression] Volatile pointer dereferenced twice Date: Fri, 17 Sep 2021 08:23:17 +0000 [thread overview] Message-ID: <bug-102306-4-R4z8qE5yMT@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102306-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102306 --- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-9 branch has been updated by Eric Botcazou <ebotcazou@gcc.gnu.org>: https://gcc.gnu.org/g:57146bfc2459424c007f4b97f29eef4c600a7b8c commit r9-9732-g57146bfc2459424c007f4b97f29eef4c600a7b8c Author: Eric Botcazou <ebotcazou@adacore.com> Date: Fri Sep 17 10:12:12 2021 +0200 Fix PR rtl-optimization/102306 This is a duplication of volatile loads introduced during GCC 9 development by the 2->2 mechanism of the RTL combiner. There is already a substantial checking for volatile references in can_combine_p but it implicitly assumes that the combination reduces the number of instructions, which is of course not the case here. So the fix teaches try_combine to abort the combination when it is about to make a copy of volatile references to preserve them. gcc/ PR rtl-optimization/102306 * combine.c (try_combine): Abort the combination if we are about to duplicate volatile references. gcc/testsuite/ * gcc.target/sparc/20210917-1.c: New test.
next prev parent reply other threads:[~2021-09-17 8:23 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-13 11:59 [Bug rtl-optimization/102306] New: " cederman at gaisler dot com 2021-09-13 12:14 ` [Bug target/102306] " rguenth at gcc dot gnu.org 2021-09-13 12:17 ` [Bug rtl-optimization/102306] " rguenth at gcc dot gnu.org 2021-09-14 13:25 ` ebotcazou at gcc dot gnu.org 2021-09-14 13:44 ` ebotcazou at gcc dot gnu.org 2021-09-14 13:58 ` ebotcazou at gcc dot gnu.org 2021-09-14 18:35 ` [Bug rtl-optimization/102306] [9/10/11/12 Regression] " pinskia at gcc dot gnu.org 2021-09-14 20:20 ` segher at gcc dot gnu.org 2021-09-14 20:23 ` segher at gcc dot gnu.org 2021-09-14 22:52 ` ebotcazou at gcc dot gnu.org 2021-09-15 7:17 ` ebotcazou at gcc dot gnu.org 2021-09-17 8:15 ` cvs-commit at gcc dot gnu.org 2021-09-17 8:19 ` cvs-commit at gcc dot gnu.org 2021-09-17 8:20 ` cvs-commit at gcc dot gnu.org 2021-09-17 8:23 ` cvs-commit at gcc dot gnu.org [this message] 2021-09-17 8:25 ` ebotcazou at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102306-4-R4z8qE5yMT@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).