* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
@ 2021-09-13 18:54 ` anlauf at gcc dot gnu.org
2021-09-13 19:13 ` anlauf at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-13 18:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-09-13
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.
(gdb) l symbol.c:4278
4273
4274 void
4275 gfc_enforce_clean_symbol_state(void)
4276 {
4277 enforce_single_undo_checkpoint ();
4278 gcc_assert (latest_undo_chgset->syms.is_empty ());
4279 }
For some reason we fail to clean up when the function is contained in a module.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
2021-09-13 18:54 ` [Bug fortran/102311] " anlauf at gcc dot gnu.org
@ 2021-09-13 19:13 ` anlauf at gcc dot gnu.org
2021-09-14 6:55 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-13 19:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
--- Comment #2 from anlauf at gcc dot gnu.org ---
Potential fix:
diff --git a/gcc/fortran/resolve.c b/gcc/fortran/resolve.c
index 8e5ed1c032c..30b96b2f597 100644
--- a/gcc/fortran/resolve.c
+++ b/gcc/fortran/resolve.c
@@ -811,7 +811,7 @@ resolve_entries (gfc_namespace *ns)
gfc_error ("Function %s at %L has entry %s with mismatched "
"characteristics", ns->entries->sym->name,
&ns->entries->sym->declared_at, el->sym->name);
- return;
+ goto cleanup;
}
else if (ts->type == BT_CHARACTER && ts->u.cl && fts->u.cl
&& (((ts->u.cl->length && !fts->u.cl->length)
@@ -917,6 +917,8 @@ resolve_entries (gfc_namespace *ns)
}
}
}
+
+cleanup:
proc->attr.access = ACCESS_PRIVATE;
proc->attr.entry_master = 1;
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
2021-09-13 18:54 ` [Bug fortran/102311] " anlauf at gcc dot gnu.org
2021-09-13 19:13 ` anlauf at gcc dot gnu.org
@ 2021-09-14 6:55 ` rguenth at gcc dot gnu.org
2021-09-14 7:21 ` marxin at gcc dot gnu.org
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-09-14 6:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |11.3
Priority|P3 |P4
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (2 preceding siblings ...)
2021-09-14 6:55 ` rguenth at gcc dot gnu.org
@ 2021-09-14 7:21 ` marxin at gcc dot gnu.org
2021-09-14 7:40 ` anlauf at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-09-14 7:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
Likely started with r12-3201-gf9809ef57005409e.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (3 preceding siblings ...)
2021-09-14 7:21 ` marxin at gcc dot gnu.org
@ 2021-09-14 7:40 ` anlauf at gcc dot gnu.org
2021-09-14 18:23 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-14 7:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
Status|NEW |ASSIGNED
Keywords| |error-recovery
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (4 preceding siblings ...)
2021-09-14 7:40 ` anlauf at gcc dot gnu.org
@ 2021-09-14 18:23 ` cvs-commit at gcc dot gnu.org
2021-09-14 18:55 ` anlauf at gcc dot gnu.org
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-14 18:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:b305ec979d9dfc8153859a62a8ab9dd43c3bfc73
commit r12-3533-gb305ec979d9dfc8153859a62a8ab9dd43c3bfc73
Author: Harald Anlauf <anlauf@gmx.de>
Date: Tue Sep 14 20:23:27 2021 +0200
Fortran - fix ICE during error recovery checking entry characteristics
gcc/fortran/ChangeLog:
PR fortran/102311
* resolve.c (resolve_entries): Attempt to recover cleanly after
rejecting mismatched function entries.
gcc/testsuite/ChangeLog:
PR fortran/102311
* gfortran.dg/entry_25.f90: New test.
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (5 preceding siblings ...)
2021-09-14 18:23 ` cvs-commit at gcc dot gnu.org
@ 2021-09-14 18:55 ` anlauf at gcc dot gnu.org
2021-09-19 19:19 ` cvs-commit at gcc dot gnu.org
2021-09-19 19:28 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-14 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
--- Comment #5 from anlauf at gcc dot gnu.org ---
For the sake of completeness: considered as "obvious"
https://gcc.gnu.org/pipermail/fortran/2021-September/056521.html
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (6 preceding siblings ...)
2021-09-14 18:55 ` anlauf at gcc dot gnu.org
@ 2021-09-19 19:19 ` cvs-commit at gcc dot gnu.org
2021-09-19 19:28 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-19 19:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:1ae01a88d35a0e2b7d7686fcb3a4fdcc2a04e9f4
commit r11-9014-g1ae01a88d35a0e2b7d7686fcb3a4fdcc2a04e9f4
Author: Harald Anlauf <anlauf@gmx.de>
Date: Tue Sep 14 20:23:27 2021 +0200
Fortran - fix ICE during error recovery checking entry characteristics
gcc/fortran/ChangeLog:
PR fortran/102311
* resolve.c (resolve_entries): Attempt to recover cleanly after
rejecting mismatched function entries.
gcc/testsuite/ChangeLog:
PR fortran/102311
* gfortran.dg/entry_25.f90: New test.
(cherry picked from commit b305ec979d9dfc8153859a62a8ab9dd43c3bfc73)
^ permalink raw reply [flat|nested] 10+ messages in thread* [Bug fortran/102311] [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278
2021-09-13 17:26 [Bug fortran/102311] New: [11/12 Regression] ICE in gfc_enforce_clean_symbol_state, at fortran/symbol.c:4278 gscfq@t-online.de
` (7 preceding siblings ...)
2021-09-19 19:19 ` cvs-commit at gcc dot gnu.org
@ 2021-09-19 19:28 ` anlauf at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: anlauf at gcc dot gnu.org @ 2021-09-19 19:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102311
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #7 from anlauf at gcc dot gnu.org ---
Should be fixed on affected branches. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 10+ messages in thread