public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102347] "fatal error: target specific builtin not available" with MMA and LTO
Date: Thu, 23 Sep 2021 07:08:44 +0000	[thread overview]
Message-ID: <bug-102347-4-mdXZUmuQXw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102347-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102347

--- Comment #9 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Peter Bergner from comment #7)
> (In reply to Martin Liška from comment #6)
> > Quickly looking at the rs6000 code, it fails here:
> > 
> > #1  0x0000000011a0993c in rs6000_invalid_builtin
> > (fncode=MMA_BUILTIN_DISASSEMBLE_ACC_INTERNAL) at
> > ../../gcc/config/rs6000/rs6000-call.c:11643
> > #2  0x0000000011a13134 in rs6000_builtin_decl (code=1603, initialize_p=true)
> > at ../../gcc/config/rs6000/rs6000-call.c:13870
> > #3  0x00000000115c3900 in unpack_ts_function_decl_value_fields
> > (bp=0x3fffffffe2f0, expr=0x3fffaf195700) at ../../gcc/tree-streamer-in.c:361
> > #4  0x00000000115c4790 in streamer_read_tree_bitfields (ib=0x3fffffffe6a0,
> > data_in=0x132d1910, expr=0x3fffaf195700) at ../../gcc/tree-streamer-in.c:528
> > #5  0x0000000010deaa28 in lto_read_tree_1 (ib=0x3fffffffe6a0,
> > data_in=0x132d1910, expr=0x3fffaf195700) at ../../gcc/lto-streamer-in.c:1697
> > 
> > which relies on rs6000_builtin_mask. Note the mask is set here:
> > rs6000_builtin_mask = rs6000_builtin_mask_calculate ();
> > 
> > where rs6000_builtin_mask_calculate is based on TARGET_* values.
> 
> Is that really the issue though?  In a non-lto compile,
> handle_pragma_target() ends up calling rs6000_option_override_internal which
> sets the TARGET_* flags for the function given the pragma options.  Where
> does LTO do that?  I think I see lto read in the default options that were
> set on the command line, but where and when does LTO set the options defined
> by the pragma?  Are they even streamed out to the fat obj file?  They could
> be there, but I'm not seeing it.

I guess the problem here is this bif checking is so early, it's when we make up
the bif function_decl tree_node, at that time the context is still the one with
default option. I may be wrong, what I understood is that the target_option is
streamed out as part of its associated function decl into decls section, when
streaming in the decls section, the decls are constructed (including function
decls with target_option and bif decls), the bif validity checking happen here.
But function decls with target_option will be used for setting current function
later when lto starts to process cgraph_node one by one. IIUC, fat obj file
should not affect since it's mainly to control normal non-lto sections
generated or not.

  parent reply	other threads:[~2021-09-23  7:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-15 12:18 [Bug lto/102347] New: " chip.kerchner at ibm dot com
2021-09-15 13:20 ` [Bug lto/102347] " linkw at gcc dot gnu.org
2021-09-15 13:36 ` [Bug target/102347] " rguenth at gcc dot gnu.org
2021-09-16 10:36 ` linkw at gcc dot gnu.org
2021-09-17  9:10 ` linkw at gcc dot gnu.org
2021-09-17  9:20 ` pinskia at gcc dot gnu.org
2021-09-17 14:15 ` marxin at gcc dot gnu.org
2021-09-21 23:53 ` bergner at gcc dot gnu.org
2021-09-23  6:51 ` linkw at gcc dot gnu.org
2021-09-23  7:08 ` linkw at gcc dot gnu.org [this message]
2021-09-23  7:26 ` rguenther at suse dot de
2021-11-26  1:59 ` linkw at gcc dot gnu.org
2021-11-30  4:51 ` cvs-commit at gcc dot gnu.org
2021-12-01 18:17 ` cvs-commit at gcc dot gnu.org
2021-12-10 13:31 ` wschmidt at gcc dot gnu.org
2021-12-15  5:48 ` cvs-commit at gcc dot gnu.org
2021-12-15  6:15 ` cvs-commit at gcc dot gnu.org
2021-12-15  8:05 ` cvs-commit at gcc dot gnu.org
2021-12-15  8:13 ` linkw at gcc dot gnu.org
2021-12-15  8:25 ` linkw at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102347-4-mdXZUmuQXw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).