public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
@ 2021-09-16 19:19 redi at gcc dot gnu.org
2021-09-16 19:24 ` [Bug libstdc++/102377] " redi at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-16 19:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
Bug ID: 102377
Summary: FAIL: 29_atomics/atomic_flag/cons/56012.cc with
-std=gnu++20
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: redi at gcc dot gnu.org
CC: rodgertq at gcc dot gnu.org
Target Milestone: ---
In file included from
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_base.h:41,^M
from
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/atomic:41,^M
from
/home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/29_atomics/atomic_flag/cons/56012.cc:21:^M
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
warning: use of 'std::hardware_destructive_interference_size'
[-Winterference-size]^M
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
note: its value can vary between compiler versions or with different '-mtune'
or '-mcpu' flags^M
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
note: if this use is part of a public ABI, change it to instead use a constant
variable you define^M
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
note: the default value for the current CPU tuning is 64 bytes^M
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
note: you can stabilize this value with '--param
hardware_destructive_interference_size=64', or disable this warning with
'-Wno-interference-size'^M
FAIL: 29_atomics/atomic_flag/cons/56012.cc (test for excess errors)
Excess errors:
/home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/bits/atomic_wait.h:194:
warning: use of 'std::hardware_destructive_interference_size'
[-Winterference-size]
This is because <bits/atomic_wait.h> uses
hardware_destructive_interference_size, which we probably don't want to do in
the library headers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/102377] FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
@ 2021-09-16 19:24 ` redi at gcc dot gnu.org
2021-09-16 22:33 ` rodgertq at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-16 19:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
The reason we don't see it in every test is that this one uses:
// { dg-options "-Wsystem-headers -Wnarrowing" }
But I think the warning is pointing out a real issue. Since the interference
sizes vary with -mtune options, we shouldn't use them in <atomic>, since that's
defining a public ABI (or will be, once our C++20 support is non-experimental).
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/102377] FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
2021-09-16 19:24 ` [Bug libstdc++/102377] " redi at gcc dot gnu.org
@ 2021-09-16 22:33 ` rodgertq at gcc dot gnu.org
2021-09-25 20:06 ` redi at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rodgertq at gcc dot gnu.org @ 2021-09-16 22:33 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
--- Comment #2 from Thomas Rodgers <rodgertq at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #1)
> The reason we don't see it in every test is that this one uses:
>
> // { dg-options "-Wsystem-headers -Wnarrowing" }
>
> But I think the warning is pointing out a real issue. Since the interference
> sizes vary with -mtune options, we shouldn't use them in <atomic>, since
> that's defining a public ABI (or will be, once our C++20 support is
> non-experimental).
Agreed.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/102377] FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
2021-09-16 19:24 ` [Bug libstdc++/102377] " redi at gcc dot gnu.org
2021-09-16 22:33 ` rodgertq at gcc dot gnu.org
@ 2021-09-25 20:06 ` redi at gcc dot gnu.org
2021-10-07 17:39 ` cvs-commit at gcc dot gnu.org
2021-10-07 17:40 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-09-25 20:06 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2021-09-25
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/102377] FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
` (2 preceding siblings ...)
2021-09-25 20:06 ` redi at gcc dot gnu.org
@ 2021-10-07 17:39 ` cvs-commit at gcc dot gnu.org
2021-10-07 17:40 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-07 17:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:
https://gcc.gnu.org/g:0e90799071ee78f712f3b58fca7000bc0a258ade
commit r12-4234-g0e90799071ee78f712f3b58fca7000bc0a258ade
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Thu Oct 7 18:28:04 2021 +0100
libstdc++: Avoid use of hardware interference non-constant [PR102377]
libstdc++-v3/ChangeLog:
PR libstdc++/102377
* include/bits/atomic_wait.h (__waiter_pool_base:_S_align):
Hardcode to 64 instead of using non-constant constant.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug libstdc++/102377] FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
` (3 preceding siblings ...)
2021-10-07 17:39 ` cvs-commit at gcc dot gnu.org
@ 2021-10-07 17:40 ` redi at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: redi at gcc dot gnu.org @ 2021-10-07 17:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102377
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-07 17:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-16 19:19 [Bug libstdc++/102377] New: FAIL: 29_atomics/atomic_flag/cons/56012.cc with -std=gnu++20 redi at gcc dot gnu.org
2021-09-16 19:24 ` [Bug libstdc++/102377] " redi at gcc dot gnu.org
2021-09-16 22:33 ` rodgertq at gcc dot gnu.org
2021-09-25 20:06 ` redi at gcc dot gnu.org
2021-10-07 17:39 ` cvs-commit at gcc dot gnu.org
2021-10-07 17:40 ` redi at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).