public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/102408] [OpenACC] omp-oacc-neuter-broadcast.cc: random() not available on all platforms Date: Tue, 21 Sep 2021 10:39:58 +0000 [thread overview] Message-ID: <bug-102408-4-thj4OThR1f@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102408-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102408 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>: https://gcc.gnu.org/g:e87789f197e47259c94349821d3446f7d959e08f commit r12-3726-ge87789f197e47259c94349821d3446f7d959e08f Author: Thomas Schwinge <thomas@codesourcery.com> Date: Tue Sep 21 08:54:49 2021 +0200 Evaluate 'random ()' to '0' in 'pass_omp_oacc_neuter_broadcast' Julian Brown, <http://mid.mail-archive.com/20210920134603.16459021@squid.athome>: | [...] the randomness shouldn't be necessary for the | correctness of the patch (i.e. it could just be "base = bounds_lo", or | indeed folded into the line after). | | The "ar.invalid ()" case happens when we fail to allocate a block of | memory in LDS space for broadcasting a particular set of variables, | and trigger a fall-back path in the broadcasting code that adds extra | barriers around the broadcast in question. I imagine I was thinking | that adding randomness could mean we can "get lucky" sometimes and | avoid needing those barriers in some cases, but in fact I don't think | that was implemented, so the randomness is useless. (Or it could just | have been leftover debug code... oops). gcc/ PR other/102408 * omp-oacc-neuter-broadcast.cc (oacc_do_neutering): Evaluate 'random ()' to '0'.
next prev parent reply other threads:[~2021-09-21 10:39 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-20 12:11 [Bug other/102408] New: " pexu@gcc-bugzilla.mail.kapsi.fi 2021-09-20 19:46 ` [Bug other/102408] " tschwinge at gcc dot gnu.org 2021-09-21 10:39 ` cvs-commit at gcc dot gnu.org [this message] 2021-09-21 10:45 ` tschwinge at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102408-4-thj4OThR1f@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).