* [Bug c/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
@ 2021-09-23 4:50 ` pinskia at gcc dot gnu.org
2021-09-23 6:28 ` [Bug tree-optimization/102463] " dcb314 at hotmail dot com
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-09-23 4:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |12.0
Severity|normal |blocker
Keywords| |ice-on-valid-code
Summary|ice in |[12 Regression] ice in
|fold_using_range::relation_ |fold_using_range::relation_
|fold_and_or |fold_and_or
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
2021-09-23 4:50 ` [Bug c/102463] [12 Regression] " pinskia at gcc dot gnu.org
@ 2021-09-23 6:28 ` dcb314 at hotmail dot com
2021-09-23 6:52 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dcb314 at hotmail dot com @ 2021-09-23 6:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #1 from David Binderman <dcb314 at hotmail dot com> ---
142 revisions in the gap, trying 24f99147b9264f8f.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
2021-09-23 4:50 ` [Bug c/102463] [12 Regression] " pinskia at gcc dot gnu.org
2021-09-23 6:28 ` [Bug tree-optimization/102463] " dcb314 at hotmail dot com
@ 2021-09-23 6:52 ` rguenth at gcc dot gnu.org
2021-09-23 6:55 ` dcb314 at hotmail dot com
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-09-23 6:52 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
CC| |aldyh at gcc dot gnu.org
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (2 preceding siblings ...)
2021-09-23 6:52 ` rguenth at gcc dot gnu.org
@ 2021-09-23 6:55 ` dcb314 at hotmail dot com
2021-09-23 7:31 ` aldyh at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dcb314 at hotmail dot com @ 2021-09-23 6:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #2 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to David Binderman from comment #1)
> 142 revisions in the gap, trying 24f99147b9264f8f.
Revision looks good, trying f6ccb788f29ce79a, although Aldy seems
to be in the frame for this one.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (3 preceding siblings ...)
2021-09-23 6:55 ` dcb314 at hotmail dot com
@ 2021-09-23 7:31 ` aldyh at gcc dot gnu.org
2021-09-23 7:50 ` dcb314 at hotmail dot com
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-09-23 7:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Could you provide a preprocessed source?
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (4 preceding siblings ...)
2021-09-23 7:31 ` aldyh at gcc dot gnu.org
@ 2021-09-23 7:50 ` dcb314 at hotmail dot com
2021-09-23 8:16 ` aldyh at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: dcb314 at hotmail dot com @ 2021-09-23 7:50 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #4 from David Binderman <dcb314 at hotmail dot com> ---
(In reply to Aldy Hernandez from comment #3)
> Could you provide a preprocessed source?
? It already is. It might need a few "int" and "void" to keep
modern C compilers happy.
I forgot to add the relevant flags to the reduce. Sorry.
Current git range is [5d110fe90afcd850..f6ccb788f29ce79a].
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (5 preceding siblings ...)
2021-09-23 7:50 ` dcb314 at hotmail dot com
@ 2021-09-23 8:16 ` aldyh at gcc dot gnu.org
2021-09-23 13:58 ` amacleod at redhat dot com
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-09-23 8:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Ever confirmed|0 |1
CC| |amacleod at redhat dot com
Last reconfirmed| |2021-09-23
--- Comment #5 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to David Binderman from comment #4)
> (In reply to Aldy Hernandez from comment #3)
> > Could you provide a preprocessed source?
>
> ? It already is. It might need a few "int" and "void" to keep
> modern C compilers happy.
>
> I forgot to add the relevant flags to the reduce. Sorry.
>
> Current git range is [5d110fe90afcd850..f6ccb788f29ce79a].
My bad. I got thrown off by the first line and assumed it was some enum
specific to bfd.
This looks like it came from Andrew's EDGE_EXECUTABLE patches:
commit 73cf73af2392e00917de042a4692f6a0b6329ee8
commit 5d110fe90afcd850ea21aee6429f22edd6b1b592
This is an ICE in relation_fold_and_or where the defining statement for an SSA
is a PHI, which obviously has no range-ops entry, so we shouldn't dereference
its handler:
range_operator *handler1 = gimple_range_handler (SSA_NAME_DEF_STMT (ssa1));
range_operator *handler2 = gimple_range_handler (SSA_NAME_DEF_STMT (ssa2));
int_range<2> bool_one (boolean_true_node, boolean_true_node);
relation_kind relation1 = handler1->op1_op2_relation (bool_one);
relation_kind relation2 = handler2->op1_op2_relation (bool_one);
SSA_NAME_DEF_STMT(ssa1) is: ntdef_10 = PHI <newdef_14(2), _3(3)>
CCing author.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (6 preceding siblings ...)
2021-09-23 8:16 ` aldyh at gcc dot gnu.org
@ 2021-09-23 13:58 ` amacleod at redhat dot com
2021-09-23 17:35 ` cvs-commit at gcc dot gnu.org
2021-09-23 17:37 ` amacleod at redhat dot com
9 siblings, 0 replies; 11+ messages in thread
From: amacleod at redhat dot com @ 2021-09-23 13:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
That trapping routine (relation_fold_and_or) is looking to see if there are
any relationships between dependencies that can be exploited. ie
c_2 = a_6 > b_7
c_3 = a_6 < b_7
c_4 = c_2 && c_3
if (c_4 != 0)
when looking at c_2 and c_3, it notes that they both depend on the same 2
ssa-names, a_6, and a_7.
It then queries whether there is a relationship between them when c_2 is [1,1]
and c_3 is [1,1]. If so, it then tries to apply that relation to see if the
stmt can never be true or not based on that raw relation.
In this case, the 2 defining stmts are both PHI nodes, which happen to have the
same 2 ssa_names in the dependency list, so it matches the pattern being looked
for:
# ntdef_6 = PHI <newdef_10(2), _bfd_elf_merge_symbol_h.0_1(3)>
# tdef_7 = PHI <_bfd_elf_merge_symbol_h.0_1(2), newdef_10(3)>
_5 = __tdef_7 & ntdef_6
both names depend on the value of newdef_10 and _bfd_elf_merge_symbol_h.0_1, so
a check is being made for a relationship between op1 and op2 in those stmts.
Whats missing is that we can only check for operand relationships in range-ops
enabled stmts... The phi will never overtly give us a relation between the
first and second operand, so no need to check.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (7 preceding siblings ...)
2021-09-23 13:58 ` amacleod at redhat dot com
@ 2021-09-23 17:35 ` cvs-commit at gcc dot gnu.org
2021-09-23 17:37 ` amacleod at redhat dot com
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-09-23 17:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:
https://gcc.gnu.org/g:fe4e6c824a580012bf9034cc33f0b440df93f56f
commit r12-3868-gfe4e6c824a580012bf9034cc33f0b440df93f56f
Author: Andrew MacLeod <amacleod@redhat.com>
Date: Thu Sep 23 09:32:00 2021 -0400
Look for a relation between operands only when possible.
Do not look for a relation between 2 operands if there is no range-ops
handler.
gcc/
PR tree-optimization/102463
* gimple-range-fold.cc (fold_using_range::relation_fold_and_or): If
there is no range-ops handler, don't look for a relation.
gcc/testsuite/
* gcc.dg/pr102463.c: New.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102463] [12 Regression] ice in fold_using_range::relation_fold_and_or
2021-09-23 4:14 [Bug c/102463] New: ice in fold_using_range::relation_fold_and_or dcb314 at hotmail dot com
` (8 preceding siblings ...)
2021-09-23 17:35 ` cvs-commit at gcc dot gnu.org
@ 2021-09-23 17:37 ` amacleod at redhat dot com
9 siblings, 0 replies; 11+ messages in thread
From: amacleod at redhat dot com @ 2021-09-23 17:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102463
Andrew Macleod <amacleod at redhat dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #8 from Andrew Macleod <amacleod at redhat dot com> ---
Fixed.
^ permalink raw reply [flat|nested] 11+ messages in thread