public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jamborm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102473] [12 Regression] 521.wrf_r 5% slower at -Ofast and generic x86_64 tuning after r12-3426-g8f323c712ea76c
Date: Mon, 27 Sep 2021 08:10:03 +0000	[thread overview]
Message-ID: <bug-102473-4-WKJ1fkGxLH@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102473-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102473

--- Comment #10 from Martin Jambor <jamborm at gcc dot gnu.org> ---
(In reply to Hongtao.liu from comment #6)
> Does it means cycles? 

Basically yes, AFAIK.  Basically I ran both versions under perf record
and then processed the output (so that is not so wide) of perf report
-n --stdio --percent-limit=2 (where -n is the thing that gives you
"samples").

> Vtune data show __module_mp_wsm5_MOD_nislfv_rain_plm has less instructions
> retired and clocksticks after my commit. And the regression comes from
> libc-2.31.so which shoud be the same.

I tend to think that any glibc from 2.29 is good enough to reproduce this.
For what it's worth, the system I tried this on has glib 2.33

My examination was very preliminary, because wrf takes ages to build,
I hoped I would point people to the important bit.  I am not sure I
succeeded though.

(In reply to Hongtao.liu from comment #8)
> 
> I'm going to revert the patch.

This is your call.  I actually dot not think that compiling wrf_r for
pre-AVX2 targets is a very important use case, the regression was just
so consistent that I thought it was worth investigating (and of course
it would be great if it could be avoided).

So it depends whether the patch has speed benefits in more common
circumstances or not.

  parent reply	other threads:[~2021-09-27  8:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 16:45 [Bug target/102473] New: " jamborm at gcc dot gnu.org
2021-09-24  6:52 ` [Bug target/102473] [12 Regression] " rguenth at gcc dot gnu.org
2021-09-24  7:39 ` crazylht at gmail dot com
2021-09-24  7:50 ` rguenth at gcc dot gnu.org
2021-09-24 10:43 ` crazylht at gmail dot com
2021-09-26  7:29 ` crazylht at gmail dot com
2021-09-27  2:01 ` crazylht at gmail dot com
2021-09-27  2:16 ` crazylht at gmail dot com
2021-09-27  7:49 ` crazylht at gmail dot com
2021-09-27  7:51 ` cvs-commit at gcc dot gnu.org
2021-09-27  8:10 ` jamborm at gcc dot gnu.org [this message]
2021-09-27  8:18 ` crazylht at gmail dot com
2021-09-27 14:27 ` hjl.tools at gmail dot com
2021-09-28  2:20 ` crazylht at gmail dot com
2021-09-28  2:24 ` hjl.tools at gmail dot com
2021-09-28  2:59 ` crazylht at gmail dot com
2022-01-20  9:53 ` rguenth at gcc dot gnu.org
2022-05-06  8:31 ` [Bug target/102473] [12/13 " jakub at gcc dot gnu.org
2022-07-26 13:27 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102473-4-WKJ1fkGxLH@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).