public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "npiggin at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/102485] -Wa,-many no longer has any effect Date: Wed, 23 Feb 2022 17:11:01 +0000 [thread overview] Message-ID: <bug-102485-4-tof0T2jxPh@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102485-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102485 Nicholas Piggin <npiggin at gmail dot com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |npiggin at gmail dot com --- Comment #6 from Nicholas Piggin <npiggin at gmail dot com> --- (In reply to Peter Bergner from comment #1) > I agree it is GCC's job to emit a ".machine CPU" directive that allows the > assembler to correctly assemble the code GCC generates. GCC already passes -m<cpu> to the assembler though. The justification for emitting the .machine directive is given as fixing a build breakage due to a build system that passes an incorrect -m<cpu> to the assembler. *That* is the broken code (if any) that should have been fixed. But instead that is hacked around in a way that breaks working code that passes down -Wa,-many option as specified. > Your test case > however uses inline asm and GCC does not know that you are using the mfppr32 > mnemonic. The assembler code you write in an inline asm is basically a > black box to the compiler. It is therefor up to the programmer to ensure > that either the -mcpu=CPU GCC option that is being used (which > emits".machine CPU" directive) is enough to assemble the mnemonics in the > inline asm or you have to emit them in your inline asm. The kernel builds with a base compatibility (say -mcpu=power4) and then has certain code paths that are dynamically taken if running on newer CPUs which use newer instructions with inline asm. This is an important usage and it's pervasive, it seems unreasonable to break it. Adding .machine directives throughout inline asm for every instruction not in the base compatibility class is pretty horrible.
next prev parent reply other threads:[~2022-02-23 17:11 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-25 21:27 [Bug target/102485] New: " pc at us dot ibm.com 2021-10-04 17:26 ` [Bug target/102485] " bergner at gcc dot gnu.org 2021-10-04 18:17 ` pc at us dot ibm.com 2021-10-05 22:11 ` segher at gcc dot gnu.org 2021-10-05 22:58 ` bergner at gcc dot gnu.org 2021-10-05 23:41 ` segher at gcc dot gnu.org 2022-02-23 17:11 ` npiggin at gmail dot com [this message] 2022-02-23 17:38 ` segher at gcc dot gnu.org 2022-02-24 1:11 ` npiggin at gmail dot com 2022-02-24 1:25 ` npiggin at gmail dot com 2022-02-24 11:07 ` amodra at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102485-4-tof0T2jxPh@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).