public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "gabravier at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/102494] New: Failure to optimize out vector reduction properly especially when using OpenMP Date: Mon, 27 Sep 2021 00:52:19 +0000 [thread overview] Message-ID: <bug-102494-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102494 Bug ID: 102494 Summary: Failure to optimize out vector reduction properly especially when using OpenMP Product: gcc Version: 12.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: gabravier at gmail dot com Target Milestone: --- #include <stdint.h> #include <stddef.h> typedef int8_t simde_int8x8_t __attribute__((__vector_size__(8))); int16_t simde_vaddlv_s8(simde_int8x8_t a) { int16_t r = 0; #pragma omp simd reduction(+:r) for (size_t i = 0 ; i < (sizeof(a) / sizeof(a[0])) ; i++) { r += a[i]; } return r; } Compiled with -O3 -fopenmp-simd, this is the output on AMD64: simde_vaddlv_s8(signed char __vector(8)): pxor xmm1, xmm1 movdqa xmm2, xmm0 pcmpgtb xmm1, xmm0 punpcklbw xmm0, xmm1 punpcklbw xmm2, xmm1 pshufd xmm0, xmm0, 78 movq QWORD PTR [rsp-24], xmm2 movq QWORD PTR [rsp-16], xmm0 movdqa xmm0, XMMWORD PTR [rsp-24] psrldq xmm0, 8 paddw xmm0, XMMWORD PTR [rsp-24] movdqa xmm1, xmm0 psrldq xmm1, 4 paddw xmm0, xmm1 movdqa xmm1, xmm0 psrldq xmm1, 2 paddw xmm0, xmm1 pextrw eax, xmm0, 0 ret This is what Clang manages: simde_vaddlv_s8(signed char __vector(8)): punpcklbw xmm0, xmm0 # xmm0 = xmm0[0,0,1,1,2,2,3,3,4,4,5,5,6,6,7,7] psraw xmm0, 8 pshufd xmm1, xmm0, 238 # xmm1 = xmm0[2,3,2,3] paddw xmm1, xmm0 pshufd xmm0, xmm1, 85 # xmm0 = xmm1[1,1,1,1] paddw xmm0, xmm1 movdqa xmm1, xmm0 psrld xmm1, 16 paddw xmm1, xmm0 movd eax, xmm1 ret Weirdly enough, removing the `#pragma omp simd reduction(+r)` slightly improves GCC's output to this: simde_vaddlv_s8(signed char __vector(8)): pxor xmm1, xmm1 movdqa xmm2, xmm0 pcmpgtb xmm1, xmm0 punpcklbw xmm0, xmm1 punpcklbw xmm2, xmm1 pshufd xmm0, xmm0, 78 paddw xmm0, xmm2 pextrw edx, xmm0, 1 pextrw eax, xmm0, 0 add eax, edx pextrw edx, xmm0, 2 add eax, edx pextrw edx, xmm0, 3 add eax, edx ret
next reply other threads:[~2021-09-27 0:52 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-27 0:52 gabravier at gmail dot com [this message] 2021-09-27 1:45 ` [Bug tree-optimization/102494] " pinskia at gcc dot gnu.org 2021-09-27 3:01 ` crazylht at gmail dot com 2021-09-27 5:08 ` [Bug tree-optimization/102494] Failure to optimize " crazylht at gmail dot com 2021-09-27 5:13 ` crazylht at gmail dot com 2021-09-27 5:55 ` crazylht at gmail dot com 2021-09-27 8:47 ` rguenth at gcc dot gnu.org 2021-09-28 6:57 ` crazylht at gmail dot com 2021-09-28 7:09 ` rguenther at suse dot de 2021-10-08 2:10 ` cvs-commit at gcc dot gnu.org 2021-10-25 21:44 ` peter at cordes dot ca 2021-10-25 22:00 ` peter at cordes dot ca 2021-10-26 8:13 ` crazylht at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102494-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).