public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/102501] [12 regression] several test case failures after r12-3876
Date: Wed, 29 Sep 2021 18:28:36 +0000	[thread overview]
Message-ID: <bug-102501-4-tgIQnUDQO1@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102501-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102501

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:

https://gcc.gnu.org/g:24e30f485bc80c823393d8fc62b65f860230e04b

commit r12-3970-g24e30f485bc80c823393d8fc62b65f860230e04b
Author: Aldy Hernandez <aldyh@redhat.com>
Date:   Tue Sep 28 17:53:57 2021 +0200

    [PR102501] Adjust jump threading testcases for ppc64* and others.

    I really don't know what to do here.  This is a bit of whack-o-mole.
    The IL is sufficiently different for various architectures that any
    tweak can cause the number of jump threads to vary.

    For the pr7745-2.c testcase, we have less threading candidates because 2
    of them now cross loop boundaries.  Interestingly, this test matches
    "Jumps threaded", not threads registered, so the block copier can
    drop threads at copying time adding further confusion.

    For example, we can register N threads, but the old copier can cancel
    N-M threads while updating the CFG for a variety of different reasons
    (removed edges, threading through loop exits, etc).  This makes the
    "Registering jump threads" not to match the total number of threads this
    test checks for with "Jumps threaded".

    The pr66752-3.c test OTOH, is just a matter of thread4 eliminating the
    "if".  I had erroneously thought it would always be eliminated by
    thread3, but we really don't care where it gets cleaned up.  All we know
    is that DCE can't depend on the early threaders doing this work, because
    it may cross loop boundaries.  I've chosen thread4 arbitrarily, but we
    could just as easily pick the ".optimized" dump.

    Sorry, I'm really at my wits end here.  I don't see any clean path
    forward, except rewrite these tests as gimple IL.  They're close to useless
    as they sit.

    gcc/testsuite/ChangeLog:

            PR testsuite/102501
            * gcc.dg/tree-ssa/pr66752-3.c: Adjust.
            * gcc.dg/tree-ssa/pr77445-2.c: Adjust.

  parent reply	other threads:[~2021-09-29 18:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 17:42 [Bug other/102501] New: " seurer at gcc dot gnu.org
2021-09-28  8:34 ` [Bug testsuite/102501] " rguenth at gcc dot gnu.org
2021-09-28 15:31 ` aldyh at gcc dot gnu.org
2021-09-28 16:32 ` aldyh at gcc dot gnu.org
2021-09-29 18:28 ` cvs-commit at gcc dot gnu.org [this message]
2021-09-29 18:29 ` aldyh at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102501-4-tgIQnUDQO1@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).