From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 033D23858C60; Tue,  2 Nov 2021 10:19:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 033D23858C60
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102505] [10/11/12 Regression] ICE in
 verify_sra_access_forest with 16 byte aligned field and virtual inheritance
 since r10-6321-g636e80eea24b780f
Date: Tue, 02 Nov 2021 10:19:44 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 12.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: jamborm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.4
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-102505-4-uZoPXwcuy7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-102505-4@http.gcc.gnu.org/bugzilla/>
References: <bug-102505-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: gcc-bugs@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-bugs mailing list <gcc-bugs.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-bugs>,
 <mailto:gcc-bugs-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Nov 2021 10:19:45 -0000

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102505

--- Comment #9 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Martin Jambor
<jamborm@gcc.gnu.org>:

https://gcc.gnu.org/g:7d398e42d3d4ded84cb7a86396c75c5aaf518283

commit r10-10249-g7d398e42d3d4ded84cb7a86396c75c5aaf518283
Author: Martin Jambor <mjambor@suse.cz>
Date:   Tue Nov 2 11:17:51 2021 +0100

    sra: Fix corner case of total scalarization with virtual inheritance (PR
102505)

    PR 102505 is a situation where of SRA takes its initial top-level
    access size from a get_ref_base_and_extent called on a COMPONENT_REF,
    and thus derived frm the FIELD_DECL, which however does not include a
    virtual base.  Total scalarization then goes on traversing the type,
    which however has virtual base past the non-virtual bits, tricking SRA
    to create sub-accesses outside of the supposedly encompassing
    accesses, which in turn triggers the verifier within the pass.

    The patch below fixes that by failing total scalarization when this
    situation is detected.

    This backport also has commit f217e87972a2a207e793101fc05cfc9dd095c678
    squashed into it in order to avoid PR 102886 that the fix introduced
    on trunk.

    gcc/ChangeLog:

    2021-10-20  Martin Jambor  <mjambor@suse.cz>

            PR tree-optimization/102505
            * tree-sra.c (totally_scalarize_subtree): Check that the
            encountered field fits within the acces we would like to put it
            in.

    gcc/testsuite/ChangeLog:

    2021-10-20  Martin Jambor  <mjambor@suse.cz>

            PR tree-optimization/102505
            * g++.dg/torture/pr102505.C: New test.

    (cherry picked from commit 701ee067807b80957c65bd7ff94b6099a27181de)=