public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/102519] [12 Regression] VRP Jump threader memory explosion
Date: Thu, 30 Sep 2021 00:18:47 +0000	[thread overview]
Message-ID: <bug-102519-4-VR4dZ7F6tA@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102519-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102519

--- Comment #16 from Aldy Hernandez <aldyh at redhat dot com> ---
On Wed, Sep 29, 2021 at 10:46 PM dje at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102519
>
> --- Comment #15 from David Edelsohn <dje at gcc dot gnu.org> ---
> I annotated execute_vrp_threader() to call getrusage() and print the size of
> RSS around each call to threader.thread_jumps().  It consistently is growing,
> but not in the threader itself.  Was the former VPR Threader intentionally or
> implicitly freeing some other data allocated by the compiler that the new
> threader is not cleaning up?

Huh.  Very good insight.

:-)

diff --git a/gcc/tree-vrp.c b/gcc/tree-vrp.c
index 69a3ab0ea9d..c24c67f8874 100644
--- a/gcc/tree-vrp.c
+++ b/gcc/tree-vrp.c
@@ -4408,6 +4408,7 @@ hybrid_threader::~hybrid_threader ()
   delete m_threader;
   delete m_state;
   delete m_ranger;
+  delete m_query;

   scev_finalize ();
   loop_optimizer_finalize ();

  parent reply	other threads:[~2021-09-30  0:18 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 18:16 [Bug middle-end/102519] New: " dje at gcc dot gnu.org
2021-09-28 18:16 ` [Bug middle-end/102519] " dje at gcc dot gnu.org
2021-09-28 18:27 ` aldyh at gcc dot gnu.org
2021-09-29  6:16 ` rguenth at gcc dot gnu.org
2021-09-29  7:51 ` aldyh at gcc dot gnu.org
2021-09-29  7:53 ` pinskia at gcc dot gnu.org
2021-09-29  7:56 ` aldyh at gcc dot gnu.org
2021-09-29 13:53 ` dje at gcc dot gnu.org
2021-09-29 15:04 ` aldyh at gcc dot gnu.org
2021-09-29 15:18 ` aldyh at gcc dot gnu.org
2021-09-29 15:22 ` aldyh at gcc dot gnu.org
2021-09-29 15:37 ` dje at gcc dot gnu.org
2021-09-29 15:59 ` dje at gcc dot gnu.org
2021-09-29 16:42 ` aldyh at gcc dot gnu.org
2021-09-29 16:58 ` dje at gcc dot gnu.org
2021-09-29 20:46 ` dje at gcc dot gnu.org
2021-09-30  0:18 ` aldyh at redhat dot com [this message]
2021-09-30  0:32 ` law at gcc dot gnu.org
2021-09-30  0:48 ` dje at gcc dot gnu.org
2021-09-30  5:49 ` aldot at gcc dot gnu.org
2021-09-30  5:55 ` aldyh at redhat dot com
2021-09-30  5:55 ` aldyh at redhat dot com
2021-09-30  6:10 ` cvs-commit at gcc dot gnu.org
2021-09-30  7:29 ` aldyh at gcc dot gnu.org
2022-01-20  9:45 ` rguenth at gcc dot gnu.org
2022-01-20 14:32 ` dje at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102519-4-VR4dZ7F6tA@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).