public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "aldyh at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102542] [12 Regression] ICE Segmentation fault since r12-3876-g4a960d548b7d7d94
Date: Fri, 01 Oct 2021 15:07:05 +0000	[thread overview]
Message-ID: <bug-102542-4-DFnKZqbceE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102542-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102542

--- Comment #7 from Aldy Hernandez <aldyh at redhat dot com> ---
On Fri, Oct 1, 2021 at 1:46 PM rguenth at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:

> > Could I inconvenience you to tweak this function with your insight?  It's a
> > tiny function, and it seems you're much more qualified to add the
> > restriction code.  If not, I'm sure I can stumble around it and send it for
> > review.
>
> Something like
>
> diff --git a/gcc/tree-ssa-threadupdate.c b/gcc/tree-ssa-threadupdate.c
> index dcabfdb30d2..b1b77e91176 100644

Thanks so much for this.  I will test it, and incorporate it with some
ideas Jeff had suggested.  Then I'll post it upstream for
review/discussion.

BTW, it seems that the code restricting paths should actually live in
the loop world...since it's the loop experts who know what is allowed
and what is problematic ;-).

  parent reply	other threads:[~2021-10-01 15:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-30 10:12 [Bug tree-optimization/102542] New: " marxin at gcc dot gnu.org
2021-09-30 10:13 ` [Bug tree-optimization/102542] " marxin at gcc dot gnu.org
2021-09-30 10:16 ` pinskia at gcc dot gnu.org
2021-09-30 16:04 ` aldyh at gcc dot gnu.org
2021-09-30 22:31 ` pinskia at gcc dot gnu.org
2021-10-01  6:18 ` rguenther at suse dot de
2021-10-01 11:18 ` aldyh at gcc dot gnu.org
2021-10-01 11:46 ` rguenth at gcc dot gnu.org
2021-10-01 15:07 ` aldyh at redhat dot com [this message]
2022-01-17 13:16 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102542-4-DFnKZqbceE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).