* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
@ 2021-10-02 14:12 ` pinskia at gcc dot gnu.org
2021-10-02 16:35 ` aldyh at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-10-02 14:12 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |aldyh at gcc dot gnu.org,
| |amacleod at redhat dot com
Target Milestone|--- |12.0
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
2021-10-02 14:12 ` [Bug tree-optimization/102560] " pinskia at gcc dot gnu.org
@ 2021-10-02 16:35 ` aldyh at gcc dot gnu.org
2021-10-02 16:48 ` aldyh at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-02 16:35 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Last reconfirmed| |2021-10-02
Status|UNCONFIRMED |NEW
--- Comment #1 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
confirmed
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
2021-10-02 14:12 ` [Bug tree-optimization/102560] " pinskia at gcc dot gnu.org
2021-10-02 16:35 ` aldyh at gcc dot gnu.org
@ 2021-10-02 16:48 ` aldyh at gcc dot gnu.org
2021-10-02 19:53 ` aldyh at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-02 16:48 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Going up the backtrace we see:
(gdb)
#3 0x0000000001b43aff in irange::intersect (this=0x7fffffffc8e0,
other=0x3c7aa40 <alloca_call_type(gimple*, bool)::invalid_range>)
at /home/aldyh/src/gcc/gcc/value-range.cc:1514
(gdb)
#4 0x0000000001b3e1e8 in irange::intersect (this=0x7fffffffc8e0, r=...)
at /home/aldyh/src/gcc/gcc/value-range.h:549
(gdb)
#5 0x0000000002a78c33 in alloca_call_type (stmt=<gimple_call 0x7fffea151240>,
is_vla=false)
at /home/aldyh/src/gcc/gcc/gimple-ssa-warn-alloca.c:229
We're intersecting with invalid_range which is a static member:
static int_range<2> invalid_range (build_int_cst (size_type_node, 0),
build_int_cst (size_type_node,
max_size),
VR_ANTI_RANGE);
It looks like it has members that have been GC freed:
(gdb) print invalid_range
$9 = {<irange> = {m_num_ranges = 1 '\001', m_max_ranges = 2 '\002', m_kind =
VR_RANGE,
m_base = 0x3c7aa50 <alloca_call_type(gimple*, bool)::invalid_range+16>},
m_ranges = {
<ggc_freed 0x7fffea157b88>, <integer_cst 0x7fffe9fe2620>, <tree 0x0>, <tree
0x0>}}
(gdb)
The m_ranges bits are trees in int_range<N>, which live in GC, and trees are
inherently GC'ish.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (2 preceding siblings ...)
2021-10-02 16:48 ` aldyh at gcc dot gnu.org
@ 2021-10-02 19:53 ` aldyh at gcc dot gnu.org
2021-10-03 17:51 ` aldyh at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-02 19:53 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Probably needs GTY markers, and possibly putting it invalid_range in file
scope.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (3 preceding siblings ...)
2021-10-02 19:53 ` aldyh at gcc dot gnu.org
@ 2021-10-03 17:51 ` aldyh at gcc dot gnu.org
2021-10-04 6:59 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-03 17:51 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #4 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
Created attachment 51540
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51540&action=edit
patch in testing
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (4 preceding siblings ...)
2021-10-03 17:51 ` aldyh at gcc dot gnu.org
@ 2021-10-04 6:59 ` rguenth at gcc dot gnu.org
2021-10-04 6:59 ` rguenth at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-10-04 6:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
+ int_range<2> invalid_range (build_int_cst (size_type_node, 0),
+ build_int_cst (size_type_node, max_size),
r.intersect (invalid_range);
is there no way to .intersect with a wide_int instead?
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (5 preceding siblings ...)
2021-10-04 6:59 ` rguenth at gcc dot gnu.org
@ 2021-10-04 6:59 ` rguenth at gcc dot gnu.org
2021-10-04 7:02 ` aldyh at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-10-04 6:59 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (6 preceding siblings ...)
2021-10-04 6:59 ` rguenth at gcc dot gnu.org
@ 2021-10-04 7:02 ` aldyh at gcc dot gnu.org
2021-10-04 11:20 ` cvs-commit at gcc dot gnu.org
2021-10-04 11:21 ` aldyh at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-04 7:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #6 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
(In reply to Richard Biener from comment #5)
> + int_range<2> invalid_range (build_int_cst (size_type_node, 0),
> + build_int_cst (size_type_node, max_size),
>
> r.intersect (invalid_range);
>
> is there no way to .intersect with a wide_int instead?
Patch is posted upstream, so you can respond there.
But no, the intersect() method is from irange to irange. I suppose when we get
rid of trees and go back to faster wide-ints for the internal representation,
we could add such a method.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (7 preceding siblings ...)
2021-10-04 7:02 ` aldyh at gcc dot gnu.org
@ 2021-10-04 11:20 ` cvs-commit at gcc dot gnu.org
2021-10-04 11:21 ` aldyh at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-10-04 11:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Aldy Hernandez <aldyh@gcc.gnu.org>:
https://gcc.gnu.org/g:fa3ccf8bfe9940b439d6cc2c38ee8da134b0ff2d
commit r12-4139-gfa3ccf8bfe9940b439d6cc2c38ee8da134b0ff2d
Author: Aldy Hernandez <aldyh@redhat.com>
Date: Sun Oct 3 19:42:10 2021 +0200
Remove static marker for range in alloca pass.
The m_ranges[] field in int_range<N> are trees, so they live in GC
space. Since invalid_range is static, it must be marked with GTY
magic. However, calculating invalid_range is not particularly slow,
or on a critical path, so we can just put it in local scope and
recalculate every time.
Tested on x86-64 Linux.
gcc/ChangeLog:
PR tree-optimization/102560
* gimple-ssa-warn-alloca.c (alloca_call_type): Remove static
marker for invalid_range.
gcc/testsuite/ChangeLog:
* g++.dg/Walloca2.C: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread* [Bug tree-optimization/102560] [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC
2021-10-02 0:59 [Bug tree-optimization/102560] New: [12 Regression] g++.dg/Walloca1.C ICE with aggressive GC jason at gcc dot gnu.org
` (8 preceding siblings ...)
2021-10-04 11:20 ` cvs-commit at gcc dot gnu.org
@ 2021-10-04 11:21 ` aldyh at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: aldyh at gcc dot gnu.org @ 2021-10-04 11:21 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102560
Aldy Hernandez <aldyh at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #8 from Aldy Hernandez <aldyh at gcc dot gnu.org> ---
fixed
^ permalink raw reply [flat|nested] 11+ messages in thread