public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/102571] FAIL: libgomp.c/../libgomp.c-c++-common/atomic-21.c execution test
Date: Wed, 06 Oct 2021 08:45:23 +0000	[thread overview]
Message-ID: <bug-102571-4-pncONJjshf@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102571-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102571

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:ba837323dbda2bca5a1c8a4c78092a88241dcfa3

commit r12-4207-gba837323dbda2bca5a1c8a4c78092a88241dcfa3
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Oct 6 10:40:12 2021 +0200

    openmp: Optimize for OpenMP atomics
2x__builtin_clear_padding+__builtin_memcmp if possible

    For the few long double types that do have padding bits, e.g. on x86
    the clear_type_padding_in_mask computed mask is
    ff ff ff ff ff ff ff ff ff ff 00 00 for 32-bit and
    ff ff ff ff ff ff ff ff ff ff 00 00 00 00 00 00 for 64-bit.
    Instead of doing __builtin_clear_padding on both operands that will clear
the
    last 2 or 6 bytes and then memcmp on the whole 12/16 bytes, we can just
    memcmp 10 bytes.  The code also handles if the padding would be at the
start
    or both at the start and end, but everything on byte boundaries only and
    non-padding bits being contiguous.
    This works around a tree-ssa-dse.c bug (but we need to fix it anyway,
    as libstdc++ won't do this and as it can deal with arbitrary types, it even
    can't do that generally).

    2021-10-06  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/102571
            * c-omp.c (c_finish_omp_atomic): Optimize the case where type has
            padding, but the non-padding bits are contiguous set of bytes
            by adjusting the memcmp call arguments instead of emitting
            __builtin_clear_padding and then comparing all the type's bytes.

  parent reply	other threads:[~2021-10-06  8:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-02 22:56 [Bug libgomp/102571] New: " hjl.tools at gmail dot com
2021-10-04 19:19 ` [Bug tree-optimization/102571] " jakub at gcc dot gnu.org
2021-10-05 14:15 ` jakub at gcc dot gnu.org
2021-10-06  8:45 ` cvs-commit at gcc dot gnu.org [this message]
2021-10-06 10:20 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102571-4-pncONJjshf@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).