public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug other/102605] address instruction from -fdump-tree-*-gimple doesn't work with -fgimple
Date: Tue, 05 Oct 2021 12:16:52 +0000	[thread overview]
Message-ID: <bug-102605-4-nJwneVm6ls@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102605-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102605

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2021-10-05

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
You need

  if (p_2(D) == _Literal (char *) &global[2])

and of course you need to provide the

char global[10];

declaration.  And then we still need to fix some sanity checking in the
frontend.

diff --git a/gcc/c/gimple-parser.c b/gcc/c/gimple-parser.c
index c8d9db61f0a..c43ee38a2cf 100644
--- a/gcc/c/gimple-parser.c
+++ b/gcc/c/gimple-parser.c
@@ -1622,16 +1622,20 @@ c_parser_gimple_postfix_expression (gimple_parser
&parser)
                  tree val = c_parser_gimple_postfix_expression (parser).value;
                  if (! val
                      || val == error_mark_node
-                     || (!CONSTANT_CLASS_P (val)
-                         && !(addr_p
-                              && (TREE_CODE (val) == STRING_CST
-                                  || DECL_P (val)))))
+                     || (!CONSTANT_CLASS_P (val) && !addr_p))
                    {
                      c_parser_error (parser, "invalid _Literal");
                      return expr;
                    }
                  if (addr_p)
-                   val = build1 (ADDR_EXPR, type, val);
+                   {
+                     val = build1 (ADDR_EXPR, type, val);
+                     if (!is_gimple_invariant_address (val))
+                       {
+                         c_parser_error (parser, "invalid _Literal");
+                         return expr;
+                       }
+                   }
                  if (neg_p)
                    {
                      val = const_unop (NEGATE_EXPR, TREE_TYPE (val), val);

  reply	other threads:[~2021-10-05 12:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-05  9:48 [Bug other/102605] New: " aldyh at gcc dot gnu.org
2021-10-05 12:16 ` rguenth at gcc dot gnu.org [this message]
2021-10-05 14:14 ` [Bug other/102605] " aldyh at gcc dot gnu.org
2021-10-05 14:37 ` cvs-commit at gcc dot gnu.org
2021-10-06  6:11 ` rguenther at suse dot de
2021-10-06  7:40 ` aldyh at redhat dot com
2021-10-06  8:13 ` rguenther at suse dot de
2021-10-06  8:28 ` aldyh at redhat dot com
2021-10-06 10:02 ` cvs-commit at gcc dot gnu.org
2021-10-07  6:21 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102605-4-nJwneVm6ls@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).