From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 858AC3857810; Thu, 20 Jan 2022 12:05:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 858AC3857810 From: "egallager at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug other/102664] contrib/gcc-git-customization.sh uses echo -n, which isn't portable Date: Thu, 20 Jan 2022 12:05:38 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: other X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: easyhack X-Bugzilla-Severity: trivial X-Bugzilla-Who: egallager at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2022 12:05:38 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102664 Eric Gallager changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |iains at gcc dot gnu.org, | |jakub at gcc dot gnu.org --- Comment #6 from Eric Gallager --- (In reply to Martin Li=C5=A1ka from comment #5) > (In reply to Eric Gallager from comment #3) > > Along these lines, there's also some non-portable usage of `expr` in the > > file, too (which I brought up on IRC), but I forget what exactly it was= ... >=20 > Do you know what exactly is problematic regarding the portability? Ah, I found my IRC log; apparently it was the `expr match` part: 1635762461 3130 hm, looks like I need to use gexpr instead = of just-plain expr T 1635762474 3130 I guess it's a GNU vs. BSD thing=20 T 1635762672 3130 so I guess that's a separate bug to file T 1635762691 3130 I guess the g:hash syntax will do for now f= or the other one I was filing=20 T 1635762767 18 yes, there are some non-portable parts in the customisation =E2=80=A6=20 T 1635762803 18 expr is used twice there, is the problem with expr match or with expr x - y T 1635762865 18* iains thought the initial problem was with the matc= h .. but ICBW T 1635762967 18 I guess it can be replaced with echo | grep -q too,= but for bash that is unnecessary slowdown...; perhaps gcc-git-customization.sh could check if expr match works and if not, use something different... T 1635763046 3130 I think it's the expr match part=