public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/102675] [12 regression] Bootstrap fails in libsanitizer: 'MD5_DIGEST_STRING_LENGTH' was not declared in this scope
Date: Tue, 16 Nov 2021 11:40:48 +0000	[thread overview]
Message-ID: <bug-102675-4-JnLYK1ul0M@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102675-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102675

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #17 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The include/md5.h part of this has been committed as
r12-4936-g44d9d55c6d0e3a1e26427662d30f350a80282634
The other change hasn't been applied from what I can see.

I wonder if we couldn't do instead:
2021-11-16  Jakub Jelinek  <jakub@redhat.com>

        PR bootstrap/102675
        * sanitizer_common/Makefile.am: Use -DUSE_SYSTEM_MD5 in AM_CXXFLAGS
        of sanitizer_platform_limits_freebsd.cpp.
        * sanitizer_common/Makefile.in: Regenerated.

--- libsanitizer/sanitizer_common/Makefile.am.jj        2021-11-05
00:43:22.647623646 +0100
+++ libsanitizer/sanitizer_common/Makefile.am   2021-11-16 12:29:58.574930436
+0100
@@ -17,6 +17,7 @@ AM_CXXFLAGS += -DSANITIZER_LIBBACKTRACE
 endif
 AM_CCASFLAGS = $(EXTRA_ASFLAGS)
 ACLOCAL_AMFLAGS = -I m4
+sanitizer_platform_limits_freebsd.lo: AM_CXXFLAGS += -DUSE_SYSTEM_MD5

 noinst_LTLIBRARIES = libsanitizer_common.la

--- libsanitizer/sanitizer_common/Makefile.in.jj        2021-11-05
00:43:22.647623646 +0100
+++ libsanitizer/sanitizer_common/Makefile.in   2021-11-16 12:30:58.611088913
+0100
@@ -796,6 +796,7 @@ uninstall-am:

 .PRECIOUS: Makefile

+sanitizer_platform_limits_freebsd.lo: AM_CXXFLAGS += -DUSE_SYSTEM_MD5

 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.

and avoid the need of a local patches for this - the Makefiles are owned by
gcc, not imported from compiler-rt, and we require GNU make for building gcc
AFAIK.

  parent reply	other threads:[~2021-11-16 11:40 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09 22:26 [Bug bootstrap/102675] New: " gerald at pfeifer dot com
2021-10-09 22:31 ` [Bug bootstrap/102675] " hjl.tools at gmail dot com
2021-10-10 21:04 ` gerald at pfeifer dot com
2021-10-10 21:22 ` hjl.tools at gmail dot com
2021-10-10 21:50 ` hjl.tools at gmail dot com
2021-10-11  9:03 ` rguenth at gcc dot gnu.org
2021-10-22 19:08 ` kargl at gcc dot gnu.org
2021-10-22 20:11 ` hjl.tools at gmail dot com
2021-10-23 13:25 ` hjl.tools at gmail dot com
2021-10-23 17:24 ` gerald at pfeifer dot com
2021-10-23 17:31 ` hjl.tools at gmail dot com
2021-10-23 17:45 ` gerald at pfeifer dot com
2021-10-23 17:46 ` gerald at pfeifer dot com
2021-10-23 18:12 ` hjl.tools at gmail dot com
2021-10-30 20:47 ` gerald at pfeifer dot com
2021-10-30 20:54 ` hjl.tools at gmail dot com
2021-11-12  1:08 ` pinskia at gcc dot gnu.org
2021-11-16 11:40 ` jakub at gcc dot gnu.org [this message]
2021-11-16 16:02 ` gerald at pfeifer dot com
2021-11-16 18:12 ` unlvsur at live dot com
2021-11-17 13:03 ` gerald at pfeifer dot com
2021-11-18  9:08 ` cvs-commit at gcc dot gnu.org
2021-11-18  9:18 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102675-4-JnLYK1ul0M@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).