public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "ott at fb dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/102712] New: std::optional::operator* should assert on unset value Date: Tue, 12 Oct 2021 15:56:19 +0000 [thread overview] Message-ID: <bug-102712-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102712 Bug ID: 102712 Summary: std::optional::operator* should assert on unset value Product: gcc Version: unknown Status: UNCONFIRMED Severity: normal Priority: P3 Component: libstdc++ Assignee: unassigned at gcc dot gnu.org Reporter: ott at fb dot com Target Milestone: --- It is UB to call operator* on an unset std::optional, and when doing so it is easy to hit time-traveling UB, resulting in behavior that is very hard to debug. For example, setting a field of an unset optional with operator-> may look like it succeeded, and the rest of the program will behave as if the optional was set, but it will silently leak memory because the destructor won't run. Another plausible scenario is having an optional<X> where X has an operator bool(), and spelling "if (*opt)" when the intention is to spell "if (opt)". The program compiles and the optional is just assumed set around the condition. Even UBSan with some of the strictest settings doesn't detect this. All major implementations of the type have defined behavior in debug builds: - libc++ asserts https://github.com/llvm-mirror/libcxx/blob/master/include/optional#L905 - boost asserts https://github.com/boostorg/optional/blob/develop/include/boost/optional/optional.hpp#L1213 - abseil asserts https://github.com/abseil/abseil-cpp/blob/master/absl/types/optional.h#L428 - folly throws (in any compilation mode) https://github.com/facebook/folly/blob/master/folly/Optional.h#L330 https://github.com/facebook/folly/blob/master/folly/Optional.h#L297 So anyone migrating from any of these is in for a world of hurt. Please consider adding an assertion in libstdc++.
next reply other threads:[~2021-10-12 15:56 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-12 15:56 ott at fb dot com [this message] 2021-10-12 16:04 ` [Bug libstdc++/102712] " redi at gcc dot gnu.org 2021-10-12 16:06 ` redi at gcc dot gnu.org 2021-10-12 16:09 ` ott at fb dot com 2022-11-28 11:08 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102712-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).