public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/102743] [12 Regression] build failure for i686-w64-mingw32 target because of patch yesterday Date: Thu, 14 Oct 2021 14:12:54 +0000 [thread overview] Message-ID: <bug-102743-4-H1fMB2bIk1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-102743-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102743 --- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:5e3f88838994b67580594c4679c839fff7cdeba0 commit r12-4404-g5e3f88838994b67580594c4679c839fff7cdeba0 Author: Jonathan Wakely <jwakely@redhat.com> Date: Thu Oct 14 13:20:57 2021 +0100 libstdc++: Fix brainwrong in path::_S_convert(T) [PR102743] This function was supposed to check whether the parameter's value type is the same as path::value_type, and therefore needs no conversion. Instead it checks whether the parameter is the same as its own value type, which is never true. This means we incorrectly return a string view for the case where T is path::string_type, instead of just returning the string itself. The only place that happens is path::_S_convert_loc for Windows, where we call _S_convert with a std::wstring rvalue. This fixes the condition in _S_convert(T). libstdc++-v3/ChangeLog: PR libstdc++/102743 * include/bits/fs_path.h (path::_S_convert(T)): Fix condition for returning the same string unchanged.
next prev parent reply other threads:[~2021-10-14 14:12 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-14 11:53 [Bug libstdc++/102743] New: " unlvsur at live dot com 2021-10-14 11:57 ` [Bug libstdc++/102743] [12 Regression] " pinskia at gcc dot gnu.org 2021-10-14 12:02 ` redi at gcc dot gnu.org 2021-10-14 14:12 ` cvs-commit at gcc dot gnu.org [this message] 2021-10-14 14:18 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102743-4-H1fMB2bIk1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).