[Bug tree-optimization/102796] New: [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[Bug tree-optimization/102796] New: [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

            Bug ID: 102796
           Summary: [12 Regresson] ICE in useless_type_conversion_p at
                    gcc/gimple-expr.c:87 since
                    r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: marxin at gcc dot gnu.org
                CC: aldyh at gcc dot gnu.org, amacleod at redhat dot com
  Target Milestone: ---

The following fails:

$ cat /home/marxin/Programming/testcases/ice.cpp
namespace std {
template <class _E>
struct initializer_list {
  const int* __begin_;
  decltype(sizeof(int)) __size_;
};
}  // namespace std
struct destroyme1 {};
struct witharg1 {
  witharg1(const destroyme1&);
  ~witharg1();
};
std::initializer_list globalInitList2 = {witharg1(destroyme1()),
                                         witharg1(destroyme1())};

$ ./xg++ -B. /home/marxin/Programming/testcases/ice.cpp -fno-tree-ccp
-fno-tree-fre -fno-tree-forwprop -O3 -c
during GIMPLE pass: evrp
/home/marxin/Programming/testcases/ice.cpp: In function ‘void
__static_initialization_and_destruction_0(int, int)’:
/home/marxin/Programming/testcases/ice.cpp:14:65: internal compiler error: tree
check: expected class ‘type’, have ‘exceptional’ (error_mark) in
useless_type_conversion_p, at gimple-expr.c:87
   14 |                                          witharg1(destroyme1())};
      |                                                                 ^
0x178e0aa tree_class_check_failed(tree_node const*, tree_code_class, char
const*, int, char const*)
        /home/marxin/Programming/gcc/gcc/tree.c:8739
0x90f81e tree_class_check(tree_node*, tree_code_class, char const*, int, char
const*)
        /home/marxin/Programming/gcc/gcc/tree.h:3556
0x90f81e useless_type_conversion_p(tree_node*, tree_node*)
        /home/marxin/Programming/gcc/gcc/gimple-expr.c:87
0x149498c verify_gimple_phi
        /home/marxin/Programming/gcc/gcc/tree-cfg.c:5128
0x149498c verify_gimple_in_cfg(function*, bool)
        /home/marxin/Programming/gcc/gcc/tree-cfg.c:5457
0x1356421 execute_function_todo
        /home/marxin/Programming/gcc/gcc/passes.c:2042
0x1355229 do_per_function
        /home/marxin/Programming/gcc/gcc/passes.c:1687
0x1356654 execute_todo
        /home/marxin/Programming/gcc/gcc/passes.c:2096
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

And it also blocks bootstrap (fails in libgo).

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-10-16
             Status|UNCONFIRMED                 |NEW
      Known to work|                            |11.2.0
      Known to fail|                            |12.0
   Target Milestone|---                         |12.0
           Priority|P3                          |P1

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #1 from Martin Liška <marxin at gcc dot gnu.org> ---
*** Bug 102797 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

--- Comment #2 from Martin Liška <marxin at gcc dot gnu.org> ---
One more test-case can be seen here:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102797#c2

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hjl.tools at gmail dot com

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
On Linux/x86, it also caused:

FAIL: 27_io/ios_base/failure/dual_abi.cc execution test

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |clyon at gcc dot gnu.org

--- Comment #4 from Christophe Lyon <clyon at gcc dot gnu.org> ---
(In reply to H.J. Lu from comment #3)
> On Linux/x86, it also caused:
> 
> FAIL: 27_io/ios_base/failure/dual_abi.cc execution test

Same on arm and aarch64

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |unlvsur at live dot com

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
*** Bug 102813 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |amacleod at redhat dot com

--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
Created attachment 51624
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=51624&action=edit
Allow EDGE_EH edges to be processed

range_on_edge needs to continue processing EDGE_EH.. 
See if this fixes all the problems. It results ina lot of UNDEFINED values
which caused no end of issues.
Its currently running through tests.

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

--- Comment #7 from H.J. Lu <hjl.tools at gmail dot com> ---
(In reply to Andrew Macleod from comment #6)
> Created attachment 51624 [details]
> Allow EDGE_EH edges to be processed
> 
> range_on_edge needs to continue processing EDGE_EH.. 
> See if this fixes all the problems. It results ina lot of UNDEFINED values
> which caused no end of issues.
> Its currently running through tests.

If it works, please remove "or EH" from comments.

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:4d92a69fc5882c86aab63d52382b393d4f20b3ed

commit r12-4486-g4d92a69fc5882c86aab63d52382b393d4f20b3ed
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Mon Oct 18 13:52:18 2021 -0400

    Process EH edges again and call get_tree_range on non gimple_range_ssa_p
names.

            PR tree-optimization/102796
            gcc/
            * gimple-range.cc (gimple_ranger::range_on_edge): Process EH edges
            normally.  Return get_tree_range for non gimple_range_ssa_p names.
            (gimple_ranger::range_of_stmt): Use get_tree_range for non
            gimple_range_ssa_p names.

            gcc/testsuite/
            * g++.dg/pr102796.C: New.

[Bug tree-optimization/102796] [12 Regresson] ICE in useless_type_conversion_p at gcc/gimple-expr.c:87 since r12-4443-g93ac832f1846e4867aa6537f76f510fab8e3e87d

[amacleod at redhat dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102796

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #9 from Andrew Macleod <amacleod at redhat dot com> ---
Should be fixed.