public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
@ 2021-10-19 7:24 marxin at gcc dot gnu.org
2021-10-19 7:24 ` [Bug bootstrap/102828] " marxin at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-19 7:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Bug ID: 102828
Summary: [12 Regression] ODR violation in
gimple-predicate-analysis.h since g:94c12ffac234
Product: gcc
Version: 12.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
Assignee: unassigned at gcc dot gnu.org
Reporter: marxin at gcc dot gnu.org
CC: msebor at gcc dot gnu.org
Target Milestone: ---
I noticed that during bootstrap and I think we should not introduce new ODR
violations, it may break LTO bootstrap.
[ 1689s] ../../gcc/ipa-predicate.h:114:7: warning: type 'struct predicate'
violates the C++ One Definition Rule [-Wodr]
[ 1689s] 114 | class predicate
[ 1689s] | ^
[ 1689s] ../../gcc/gimple-predicate-analysis.h:48: note: a different type is
defined in another translation unit
[ 1689s] 48 | class predicate
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
@ 2021-10-19 7:24 ` marxin at gcc dot gnu.org
2021-10-19 7:44 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-10-19 7:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2021-10-19
Status|UNCONFIRMED |NEW
Target Milestone|--- |12.0
Known to fail| |12.0
Known to work| |11.2.0
Ever confirmed|0 |1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
2021-10-19 7:24 ` [Bug bootstrap/102828] " marxin at gcc dot gnu.org
@ 2021-10-19 7:44 ` rguenth at gcc dot gnu.org
2021-10-19 17:30 ` msebor at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2021-10-19 7:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Yes, we should rename one instance.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
2021-10-19 7:24 ` [Bug bootstrap/102828] " marxin at gcc dot gnu.org
2021-10-19 7:44 ` rguenth at gcc dot gnu.org
@ 2021-10-19 17:30 ` msebor at gcc dot gnu.org
2021-10-24 7:11 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: msebor at gcc dot gnu.org @ 2021-10-19 17:30 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Martin Sebor <msebor at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hubicka at gcc dot gnu.org
--- Comment #2 from Martin Sebor <msebor at gcc dot gnu.org> ---
Both classes are defined in a header and used in .c/.cc files so they both need
to be public. One either needs to be renamed or put in some namespace.
The predicate defined in ipa-predicate.h is used by IPA (ipa-fnsummary.c and
ipa-predicate.c), the one in gimple-predicate-analysis.h only by
-Wuninitialized for now (tree-ssa-uninit.c) with the goal of being used by
other middle end warnings in the future.
It would be easier for me to rename the one in gimple-predicate-analysis.h but
I'm not coming up with a good name. On the other hand, it seems that the one
in ipa-predicate.h could well be named ipa_predicate. Wrapping all IPA types
and functions in their own namespace (like ipa) seems even more appealing to me
but it would be a lot of churn, probably too much at this point.
Honza, your thoughts/preference?
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
` (2 preceding siblings ...)
2021-10-19 17:30 ` msebor at gcc dot gnu.org
@ 2021-10-24 7:11 ` pinskia at gcc dot gnu.org
2021-11-03 9:37 ` marxin at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2021-10-24 7:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |blocker
Keywords| |build, internal-improvement
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
` (3 preceding siblings ...)
2021-10-24 7:11 ` pinskia at gcc dot gnu.org
@ 2021-11-03 9:37 ` marxin at gcc dot gnu.org
2021-11-03 13:02 ` cvs-commit at gcc dot gnu.org
2021-11-03 13:04 ` marxin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-03 9:37 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |marxin at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
> the one in ipa-predicate.h could well be named ipa_predicate. Wrapping all
I like the idea of renaming it to ipa_predicate and I have a patch for it.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
` (4 preceding siblings ...)
2021-11-03 9:37 ` marxin at gcc dot gnu.org
@ 2021-11-03 13:02 ` cvs-commit at gcc dot gnu.org
2021-11-03 13:04 ` marxin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2021-11-03 13:02 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Liska <marxin@gcc.gnu.org>:
https://gcc.gnu.org/g:2d01bef2f214bb80dca0e91c14e95cf4d76b0afb
commit r12-4861-g2d01bef2f214bb80dca0e91c14e95cf4d76b0afb
Author: Martin Liska <mliska@suse.cz>
Date: Wed Nov 3 10:38:21 2021 +0100
Rename predicate class to ipa_predicate
PR bootstrap/102828
gcc/ChangeLog:
* ipa-fnsummary.c (edge_predicate_pool): Rename predicate class to
ipa_predicate.
(ipa_fn_summary::account_size_time): Likewise.
(edge_set_predicate): Likewise.
(set_hint_predicate): Likewise.
(add_freqcounting_predicate): Likewise.
(evaluate_conditions_for_known_args): Likewise.
(evaluate_properties_for_edge): Likewise.
(remap_freqcounting_preds_after_dup): Likewise.
(ipa_fn_summary_t::duplicate): Likewise.
(set_cond_stmt_execution_predicate): Likewise.
(set_switch_stmt_execution_predicate): Likewise.
(compute_bb_predicates): Likewise.
(will_be_nonconstant_expr_predicate): Likewise.
(will_be_nonconstant_predicate): Likewise.
(phi_result_unknown_predicate): Likewise.
(predicate_for_phi_result): Likewise.
(analyze_function_body): Likewise.
(compute_fn_summary): Likewise.
(summarize_calls_size_and_time): Likewise.
(estimate_calls_size_and_time): Likewise.
(ipa_call_context::estimate_size_and_time): Likewise.
(remap_edge_summaries): Likewise.
(remap_freqcounting_predicate): Likewise.
(ipa_merge_fn_summary_after_inlining): Likewise.
(ipa_update_overall_fn_summary): Likewise.
(read_ipa_call_summary): Likewise.
(inline_read_section): Likewise.
* ipa-fnsummary.h (struct ipa_freqcounting_predicate): Likewise.
* ipa-predicate.c (predicate::add_clause): Likewise.
(ipa_predicate::add_clause): Likewise.
(predicate::or_with): Likewise.
(ipa_predicate::or_with): Likewise.
(predicate::evaluate): Likewise.
(ipa_predicate::evaluate): Likewise.
(predicate::probability): Likewise.
(ipa_predicate::probability): Likewise.
(dump_condition): Likewise.
(dump_clause): Likewise.
(predicate::dump): Likewise.
(ipa_predicate::dump): Likewise.
(predicate::debug): Likewise.
(ipa_predicate::debug): Likewise.
(predicate::remap_after_duplication): Likewise.
(ipa_predicate::remap_after_duplication): Likewise.
(predicate::remap_after_inlining): Likewise.
(ipa_predicate::remap_after_inlining): Likewise.
(predicate::stream_in): Likewise.
(ipa_predicate::stream_in): Likewise.
(predicate::stream_out): Likewise.
(ipa_predicate::stream_out): Likewise.
(add_condition): Likewise.
* ipa-predicate.h (class predicate): Likewise.
(class ipa_predicate): Likewise.
(add_condition): Likewise.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug bootstrap/102828] [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
` (5 preceding siblings ...)
2021-11-03 13:02 ` cvs-commit at gcc dot gnu.org
@ 2021-11-03 13:04 ` marxin at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: marxin at gcc dot gnu.org @ 2021-11-03 13:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102828
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-11-03 13:04 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 7:24 [Bug bootstrap/102828] New: [12 Regression] ODR violation in gimple-predicate-analysis.h since g:94c12ffac234 marxin at gcc dot gnu.org
2021-10-19 7:24 ` [Bug bootstrap/102828] " marxin at gcc dot gnu.org
2021-10-19 7:44 ` rguenth at gcc dot gnu.org
2021-10-19 17:30 ` msebor at gcc dot gnu.org
2021-10-24 7:11 ` pinskia at gcc dot gnu.org
2021-11-03 9:37 ` marxin at gcc dot gnu.org
2021-11-03 13:02 ` cvs-commit at gcc dot gnu.org
2021-11-03 13:04 ` marxin at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).