public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libgomp/102838] [12 regression] Several tests SEGV in gomp_loop_ull_init
Date: Thu, 18 Nov 2021 08:15:31 +0000	[thread overview]
Message-ID: <bug-102838-4-kjPESJJ08g@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102838-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102838

--- Comment #18 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:17da2c7425ea1f5bf417b954f444dbe1f1618a1c

commit r12-5362-g17da2c7425ea1f5bf417b954f444dbe1f1618a1c
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Nov 18 09:10:40 2021 +0100

    libgomp: Ensure that either gomp_team is properly aligned [PR102838]

    struct gomp_team has struct gomp_work_share array inside of it.
    If that latter structure has 64-byte aligned member in the middle,
    the whole struct gomp_team needs to be 64-byte aligned, but we weren't
    allocating it using gomp_aligned_alloc.

    This patch fixes that, except that on gcn team_malloc is special, so
    I've instead decided at least for now to avoid using aligned member
    and use the padding instead on gcn.

    2021-11-18  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/102838
            * libgomp.h (GOMP_USE_ALIGNED_WORK_SHARES): Define if
            GOMP_HAVE_EFFICIENT_ALIGNED_ALLOC is defined and __AMDGCN__ is not.
            (struct gomp_work_share): Use GOMP_USE_ALIGNED_WORK_SHARES instead
of
            GOMP_HAVE_EFFICIENT_ALIGNED_ALLOC.
            * work.c (alloc_work_share, gomp_work_share_start): Likewise.
            * team.c (gomp_new_team): If GOMP_USE_ALIGNED_WORK_SHARES, use
            gomp_aligned_alloc instead of team_malloc.

  parent reply	other threads:[~2021-11-18  8:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-19 13:03 [Bug libgomp/102838] New: " ro at gcc dot gnu.org
2021-10-19 13:03 ` [Bug libgomp/102838] " ro at gcc dot gnu.org
2021-10-19 13:12 ` jakub at gcc dot gnu.org
2021-10-19 14:01 ` jakub at gcc dot gnu.org
2021-10-19 14:22 ` jakub at gcc dot gnu.org
2021-10-20  7:40 ` cvs-commit at gcc dot gnu.org
2021-10-20 13:21 ` jakub at gcc dot gnu.org
2021-10-20 13:43 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-10-21 14:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-10-21 14:16 ` jakub at gcc dot gnu.org
2021-10-21 14:22 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-10-21 14:23 ` ro at gcc dot gnu.org
2021-10-21 14:37 ` jakub at gcc dot gnu.org
2021-11-08 10:16 ` tschwinge at gcc dot gnu.org
2021-11-16 11:19 ` jakub at gcc dot gnu.org
2021-11-17 12:08 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-11-17 12:38 ` jakub at gcc dot gnu.org
2021-11-17 13:05 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-11-18  8:10 ` cvs-commit at gcc dot gnu.org
2021-11-18  8:15 ` cvs-commit at gcc dot gnu.org [this message]
2021-11-18 12:12 ` jakub at gcc dot gnu.org
2021-11-19 12:12 ` ro at gcc dot gnu.org
2021-11-19 15:32 ` jakub at gcc dot gnu.org
2021-11-23 12:35 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-102838-4-kjPESJJ08g@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).