[Bug libgomp/102841] New: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[Bug libgomp/102841] New: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

            Bug ID: 102841
           Summary: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_dat
                    a-7.c FAILs
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org, tschwinge at gcc dot gnu.org
  Target Milestone: ---
            Target: i?86-pc-solaris2.11, x86_64-pc-solaris2.11,
                    i?86-apple-darwin*, x86_64-apple-darwin*

The libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c has been
FAILing
on Solaris and Darwin since it was installed.

FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c
-DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for
excess errors)
FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/host_data-7.c
-DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for
excess errors)

On Solaris, the excess errors are

Excess errors:
/vol/gcc/src/hg/master/local/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:21:9:
note: variable 'iftmp.3' declared in block isn't candidate for adjusting
OpenACC privatization level: not addressable
/vol/gcc/src/hg/master/local/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:26:9:
note: variable 'iftmp.6' declared in block isn't candidate for adjusting
OpenACC privatization level: not addressable
/vol/gcc/src/hg/master/local/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:33:9:
note: variable 'iftmp.9' declared in block isn't candidate for adjusting
OpenACC privatization level: not addressable
/vol/gcc/src/hg/master/local/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:44:9:
note: variable 'iftmp.12' declared in block isn't candidate for adjusting
OpenACC privatization level: not addressable
/vol/gcc/src/hg/master/local/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:55:9:
note: variable 'iftmp.15' declared in block isn't candidate for adjusting
OpenACC privatization level: not addressable

while Darwin shows

Excess errors:
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:21:9:
note: variable 'D.3648' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:21:9:
note: variable 'D.3649' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:21:9:
note: variable 'D.3650' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:33:9:
note: variable 'D.3662' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:33:9:
note: variable 'D.3663' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
/vol/gcc/src/hg/master/darwin/libgomp/testsuite/libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c:33:9:
note: variable 'D.3664' declared in block isn't candidate for adjusting OpenACC
privatization level: not addressable
[...]

[Bug libgomp/102841] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |12.0

[Bug testsuite/102841] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|libgomp                     |testsuite
           Keywords|                            |openacc
           Assignee|unassigned at gcc dot gnu.org      |tschwinge at gcc dot gnu.org
   Last reconfirmed|                            |2021-10-19
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Thanks for the report, I'll have a look (next month).

(In reply to Rainer Orth from comment #0)
> The libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c has been
> FAILing
> on Solaris and Darwin since it was installed.

Probably not since it was originally added in commit
d5c23c6ceacf666f218676b648801379044e326a 'OpenACC – support "if" + "if_present"
clauses with "host_data"', but rather in my more recentish commit
11b8286a83289f5b54e813f14ff56d730c3f3185 "[OpenACC privatization] Largely
extend diagnostics and corresponding testsuite coverage [PR90115]".  (Or, if it
indeed has been FAILing before, then it must be a different problem.)

> On Solaris, the excess errors are

> [...]: note: variable 'iftmp.3' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable

> while Darwin shows

> [...]: note: variable 'D.3648' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable

Please do tell if there are further such "[is/isn't] candidate for adjusting
OpenACC privatization level" diagnostic mismatches (excess errors, or FAILs),
in other testcases.  (But indeed per a quick scan of
<gcc-testresults@gcc.gnu.org> posts, it's just
'libgomp.oacc-c-c++-common/host_data-7.c', and it PASSed before my
"diagnostics" commit.)

[Bug testsuite/102841] [12 regression] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|libgomp.oacc-c++/../libgomp |[12 regression]
                   |.oacc-c-c++-common/host_dat |libgomp.oacc-c++/../libgomp
                   |a-7.c FAILs                 |.oacc-c-c++-common/host_dat
                   |                            |a-7.c FAILs
             Target|i?86-pc-solaris2.11,        |*-*-solaris2.11,
                   |x86_64-pc-solaris2.11,      |i?86-apple-darwin*,
                   |i?86-apple-darwin*,         |x86_64-apple-darwin*
                   |x86_64-apple-darwin*        |

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
(In reply to Thomas Schwinge from comment #1)

> (In reply to Rainer Orth from comment #0)
> > The libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c has been
> > FAILing
> > on Solaris and Darwin since it was installed.
> 
> Probably not since it was originally added in commit
> d5c23c6ceacf666f218676b648801379044e326a 'OpenACC – support "if" +
> "if_present" clauses with "host_data"', but rather in my more recentish
> commit 11b8286a83289f5b54e813f14ff56d730c3f3185 "[OpenACC privatization]
> Largely extend diagnostics and corresponding testsuite coverage [PR90115]". 
> (Or, if it indeed has been FAILing before, then it must be a different
> problem.)

Right, I didn't look closely enough.  In fact, the test is PASSing on the
gcc-11 branch,so this is even a regression.

Besides, it affects Solaris/SPARC and x86 alike, so is not x86-specific.

> > On Solaris, the excess errors are
> 
> > [...]: note: variable 'iftmp.3' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable
> 
> > while Darwin shows
> 
> > [...]: note: variable 'D.3648' declared in block isn't candidate for adjusting OpenACC privatization level: not addressable
> 
> Please do tell if there are further such "[is/isn't] candidate for adjusting
> OpenACC privatization level" diagnostic mismatches (excess errors, or
> FAILs), in other testcases.  (But indeed per a quick scan of
> <gcc-testresults@gcc.gnu.org> posts, it's just
> 'libgomp.oacc-c-c++-common/host_data-7.c', and it PASSed before my
> "diagnostics" commit.)

No, this is the only instance.

[Bug testsuite/102841] [12 regression] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Thomas Schwinge <tschwinge@gcc.gnu.org>:

https://gcc.gnu.org/g:ab46fc7c3bf01337ea4554f08f4f6b0be8173557

commit r12-7663-gab46fc7c3bf01337ea4554f08f4f6b0be8173557
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Wed Mar 16 08:02:39 2022 +0100

    OpenACC privatization diagnostics vs. 'assert' [PR102841]

    It's an orthogonal concern why these diagnostics do appear at all for
    non-offloaded OpenACC constructs (where they're not relevant at all);
PR90115.

    Depending on how 'assert' is implemented, it may cause temporaries to be
    created, and/or may lower into 'COND_EXPR's, and
    'gcc/gimplify.cc:gimplify_cond_expr' uses 'create_tmp_var (type, "iftmp")'.

    Fix-up for commit 11b8286a83289f5b54e813f14ff56d730c3f3185
    "[OpenACC privatization] Largely extend diagnostics and
    corresponding testsuite coverage [PR90115]".

            PR testsuite/102841
            libgomp/
            * testsuite/libgomp.oacc-c-c++-common/host_data-7.c: Adjust.

[Bug testsuite/102841] [12 regression] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |iains at gcc dot gnu.org
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=90115
         Resolution|---                         |FIXED

--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
Can't (easily) test due to corresponding Solaris/Darwin system
non-availability, but I think I understand the issue, and it should now be
fixed.  Please re-open if not.

Also putting Iain in CC, who for Darwin configurations also has a lot of
<gcc-testresults@gcc.gnu.org> reports for this:

    FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/host_data-7.c
-DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for
excess errors)
    FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c
-DACC_DEVICE_TYPE_host=1 -DACC_MEM_SHARED=1 -foffload=disable  -O2  (test for
excess errors)

[Bug testsuite/102841] [12 regression] libgomp.oacc-c++/../libgomp.oacc-c-c++-common/host_data-7.c FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102841

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
> Can't (easily) test due to corresponding Solaris/Darwin system
> non-availability, but I think I understand the issue, and it should now be
> fixed.  Please re-open if not.

The failures are gone in last night's i386-pc-solaris2.11 and
sparc-sun-solaris2.11 bootstraps.  Thanks.