public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/102847] [12 regression] r12-4504 breaks powerpc64 build on power 7
Date: Thu, 21 Oct 2021 09:49:09 +0000 [thread overview]
Message-ID: <bug-102847-4-mb8WwSMgpd@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-102847-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102847
--- Comment #9 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 21 Oct 2021, linkw at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102847
>
> --- Comment #8 from Kewen Lin <linkw at gcc dot gnu.org> ---
> (In reply to Richard Biener from comment #5)
> > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c
> > index 9cbc1af4cc9..8f527452bd0 100644
> > --- a/gcc/tree-vect-stmts.c
> > +++ b/gcc/tree-vect-stmts.c
> > @@ -1191,6 +1191,13 @@ vect_model_load_cost (vec_info *vinfo,
> > ncopies * assumed_nunits,
> > scalar_load, stmt_info, 0, vect_body);
> > }
> > + else if (memory_access_type == VMAT_INVARIANT)
> > + {
> > + /* Invariant loads will ideally be hoisted and splat to a vector. */
> > + prologue_cost += record_stmt_cost (cost_vec, 1,
> > + scalar_to_vec, stmt_info, 0,
> > + vect_prologue);
> > + }
> > else
> > vect_get_load_cost (vinfo, stmt_info, ncopies,
> > alignment_support_scheme, misalignment, first_stmt_p,
> >
> > should fix that in a better way.
>
> Nice, I confirmed this change can fix the issue. Thanks!
>
> For costing, it seems we need one more scalar_load costing for vect_prologue?
> or here we aggressively consider scalar_to_vec is also for load_and_splat?
Yeah, true. Let me follow up.
next prev parent reply other threads:[~2021-10-21 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:31 [Bug bootstrap/102847] New: " seurer at gcc dot gnu.org
2021-10-19 21:17 ` [Bug bootstrap/102847] " pinskia at gcc dot gnu.org
2021-10-19 21:20 ` [Bug target/102847] " pinskia at gcc dot gnu.org
2021-10-20 6:53 ` marxin at gcc dot gnu.org
2021-10-20 14:23 ` seurer at gcc dot gnu.org
2021-10-21 7:30 ` linkw at gcc dot gnu.org
2021-10-21 8:21 ` rguenth at gcc dot gnu.org
2021-10-21 9:21 ` cvs-commit at gcc dot gnu.org
2021-10-21 9:21 ` rguenth at gcc dot gnu.org
2021-10-21 9:45 ` linkw at gcc dot gnu.org
2021-10-21 9:49 ` rguenther at suse dot de [this message]
2021-10-21 11:04 ` cvs-commit at gcc dot gnu.org
2021-10-21 15:26 ` seurer at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-102847-4-mb8WwSMgpd@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).