public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "msebor at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/102849] New: missing warning for unsigned bitfield tests for negativity Date: Tue, 19 Oct 2021 22:01:03 +0000 [thread overview] Message-ID: <bug-102849-4@http.gcc.gnu.org/bugzilla/> (raw) https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102849 Bug ID: 102849 Summary: missing warning for unsigned bitfield tests for negativity Product: gcc Version: 12.0 Status: UNCONFIRMED Severity: normal Priority: P3 Component: c Assignee: unassigned at gcc dot gnu.org Reporter: msebor at gcc dot gnu.org Target Milestone: --- GCC warns for less than comparisons of unsigned integers to zero but it fails to do the same for unsigned bit-fields (likely because they promote to int; comparisons of unsigned bit-fields larger than int are diagnosed by -Wtype-limits). Diagnosing both kinds of expressions would be helpful. $ cat x.c && gcc -S -Wall -Wextra x.c struct A { unsigned i, j: 3; }; void f (struct A *p) { p->i = -1; // missing warning p->j = -1; // missing warning in C, -Woverflow in C++ } void g (struct A *p) { if (p->i < 0) // -Wtype-limits in both C and C++, folded to false __builtin_abort (); } void h (struct A *p) { if (p->j < 0) // missing warning in both C and C++, folded to false __builtin_abort (); } x.c: In function ‘g’: x.c:14:12: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits] 14 | if (p->i < 0) // -Wtype-limits in both C and C++, folded to false | ^
reply other threads:[~2021-10-19 22:01 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-102849-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).