From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id B7572385802B; Thu, 21 Oct 2021 07:53:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7572385802B From: "aldyh at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/102861] [12 regression] gcc.dg/vect/bb-slp-16.c fails after r12-4526 Date: Thu, 21 Oct 2021 07:53:29 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: testsuite X-Bugzilla-Version: 12.0 X-Bugzilla-Keywords: wrong-code X-Bugzilla-Severity: normal X-Bugzilla-Who: aldyh at gcc dot gnu.org X-Bugzilla-Status: ASSIGNED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: rguenth at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: gcc-bugs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-bugs mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Oct 2021 07:53:29 -0000 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D102861 --- Comment #6 from Aldy Hernandez --- > > Is there something else we could do? >=20 > Look what exactly is missing and restore that - testcases are written > from real-world code that we expect to optimize, adjusting them to > hide the fact that we don't any longer is not good. >=20 > Even XFAIL would have been better. Heh. That was my original suggestion, but I was vetoed :). >=20 > That said, loop header copying is supposed to do the rotation. >=20 > Note what I see on the unchanged testcase is that we now loop vectorize > which is great (and obviously no BB vectorization opportunity remains). > So a different fix would be to simply add >=20 > /* Avoid loop vectorization. */ > /* { dg-additional-options "-fno-tree-loop-vectorize" } */ >=20 > which makes the testcase PASS again (bonus for adding a variant > of the testcase that verifies we loop vectorize this). >=20 > Let me do all this for you. Thanks so much!=