public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libffi/102874] New: [12 regression] src/x86/win64.S doesn't assemble with Solaris as
@ 2021-10-21  9:36 ro at gcc dot gnu.org
  2021-10-21  9:38 ` [Bug libffi/102874] " ro at gcc dot gnu.org
                   ` (11 more replies)
  0 siblings, 12 replies; 13+ messages in thread
From: ro at gcc dot gnu.org @ 2021-10-21  9:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102874

            Bug ID: 102874
           Summary: [12 regression] src/x86/win64.S doesn't assemble with
                    Solaris as
           Product: gcc
           Version: 12.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libffi
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: hjl.tools at gmail dot com
  Target Milestone: ---
            Target: i?86-pc-solaris2.11, x86_64-pc-solaris2.11

The libffi 3.4.2 import badly broke Solaris/x86 bootstrap with the native
assembler:

Assembler:
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 88 :
Illegal mnemonic
        Near line: ".macro epilogue"
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 88 : Syntax
error
        Near line: ".macro epilogue"
config.status: creating Makefile
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 95 :
Illegal mnemonic
        Near line: ".endm"
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 95 : Syntax
error
        Near line: ".endm"
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 100 :
Illegal mnemonic
        Near line: " epilogue"
        "/vol/gcc/src/hg/master/local/libffi/src/x86/win64.S", line 100 :
Syntax error
        Near line: "epilogue"

/bin/as doesn't support .macro/.endm.

I initially tried to exclude ffiw64.c and win64.S from SOURCES in
configure.host.
While this fixed the build, it made all 64-bit libffi and libgo link tests
FAIL with unresolved references to *_efi64 functions.

While I wonder why libffi on a Unix system needs win64 support, the fix seems
simple: just use #define instead of .macro/.endm to define epilogue.  The
attached patch does that and brings things back to normal.

^ permalink raw reply	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-11-15  9:42 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-21  9:36 [Bug libffi/102874] New: [12 regression] src/x86/win64.S doesn't assemble with Solaris as ro at gcc dot gnu.org
2021-10-21  9:38 ` [Bug libffi/102874] " ro at gcc dot gnu.org
2021-10-21  9:38 ` ro at gcc dot gnu.org
2021-10-21 11:24 ` hjl.tools at gmail dot com
2021-10-21 21:10 ` ro at CeBiTec dot Uni-Bielefeld.DE
2021-10-21 22:09 ` hjl.tools at gmail dot com
2021-11-05 13:47 ` rguenth at gcc dot gnu.org
2021-11-05 15:08 ` hjl.tools at gmail dot com
2021-11-13  1:39 ` hp at gcc dot gnu.org
2021-11-13  6:31 ` hjl.tools at gmail dot com
2021-11-15  9:17 ` ro at gcc dot gnu.org
2021-11-15  9:30 ` cvs-commit at gcc dot gnu.org
2021-11-15  9:42 ` ro at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).